From: Samuel Ortiz <sameo@linux.intel.com>
To: Chao Xie <chao.xie@marvell.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
xiechao.mail@gmail.com
Subject: Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL
Date: Tue, 20 Aug 2013 03:40:42 +0200 [thread overview]
Message-ID: <20130820014042.GF13324@zurbaran> (raw)
In-Reply-To: <1376875675-11286-2-git-send-email-chao.xie@marvell.com>
Hi Xie,
On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote:
> User pass platform data to device, and platform data may be
> NULL.
In which case do you get that ? With DT ?
Should rtc_init fail when pdata is NULL ?
You need to explain that, be it only for us to know if it's a critical
fix or not.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-08-20 1:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 1:27 [PATCH 0/2] mfd: 88pm8xx: platform data bug fix Chao Xie
2013-08-19 1:27 ` [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL Chao Xie
2013-08-20 1:40 ` Samuel Ortiz [this message]
2013-08-27 6:11 ` Chao Xie
2013-08-30 12:30 ` Samuel Ortiz
2013-09-02 1:21 ` Chao Xie
2013-09-02 8:50 ` Samuel Ortiz
2013-08-19 1:27 ` [PATCH 2/2] mfd: 88pm805: " Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820014042.GF13324@zurbaran \
--to=sameo@linux.intel.com \
--cc=chao.xie@marvell.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox