* Re: [patch] filemap: add missing unlock_page
[not found] <20130909081822.8D4DF428001@webmail.sinamail.sina.com.cn>
@ 2013-09-09 7:51 ` Kirill A. Shutemov
0 siblings, 0 replies; only message in thread
From: Kirill A. Shutemov @ 2013-09-09 7:51 UTC (permalink / raw)
To: Hillf Danton
Cc: linux-mm, linux-kernel, Hugh Dickins, Andrew Morton, Jan Kara,
Hillf Danton
On Mon, Sep 09, 2013 at 04:18:22PM +0800, Hillf Danton wrote:
> Unlock and release page before returning error.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/mm/filemap.c Mon Sep 9 15:51:28 2013
> +++ b/mm/filemap.c Mon Sep 9 15:52:54 2013
> @@ -1844,6 +1844,7 @@ retry:
> }
> err = filler(data, page);
> if (err < 0) {
> + unlock_page(page);
> page_cache_release(page);
> return ERR_PTR(err);
> }
NAK. filler() should unlock the page.
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-09-09 8:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130909081822.8D4DF428001@webmail.sinamail.sina.com.cn>
2013-09-09 7:51 ` [patch] filemap: add missing unlock_page Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox