From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, rmallon@gmail.com
Cc: akpm@linux-foundation.org, dan.j.rosenberg@gmail.com,
eldad@fogrefinery.com, jkosina@suse.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Check real user/group id for %pK
Date: 29 Sep 2013 19:41:46 -0400 [thread overview]
Message-ID: <20130929234146.31004.qmail@science.horizon.com> (raw)
In-Reply-To: <5248B724.8060408@gmail.com>
> Right, so the pppd application is actually doing the correct thing.
And a CAP_SYSLOG setuid binary that *doesn't* DTRT seems like a more
immediate security hole than leaking kernel addresses. After all
kptr_restrict is optional precisely because the benefit is marginal.
The interesting question is what credentials make sense for %pK outside
of a seq_printf(). Does it even make sense in a generic printk? In that
case, it's the permission of the syslogd that matters rather than the
process generating the message.
> Will wait and see what others have to say.
Me, too. Dan in particular.
next prev parent reply other threads:[~2013-09-29 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 22:35 [PATCH] printk: Check real user/group id for %pK Ryan Mallon
2013-09-29 23:15 ` George Spelvin
2013-09-29 23:26 ` Ryan Mallon
2013-09-29 23:41 ` George Spelvin [this message]
2013-09-30 0:41 ` Dan Rosenberg
2013-09-30 0:56 ` Ryan Mallon
2013-09-30 0:59 ` Dan Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130929234146.31004.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.rosenberg@gmail.com \
--cc=eldad@fogrefinery.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox