[REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

[REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

[Laxman Dewangan]

Driver throw the warning message if dt node does not
have the info for VMBCH-Threshold and VMBCH2-Threshold.
These properties are optional property and hence it
is not mandatory to have these on DT node and in this case
it should not throw the warning message.
It creates noise from driver as follows:
[    0.384605] tps65910 4-002d: VMBCH-Threshold not specified
[    0.384616] tps65910 4-002d: VMBCH2-Threshold not specified

Removing the warning message from driver.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
It seems orginal patch has been lost. Reposting it.

 drivers/mfd/tps65910.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index ca90294..665e1b6 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -184,14 +184,10 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
 	ret = of_property_read_u32(np, "ti,vmbch-threshold", &prop);
 	if (!ret)
 		board_info->vmbch_threshold = prop;
-	else if (*chip_id == TPS65911)
-		dev_warn(&client->dev, "VMBCH-Threshold not specified");
 
 	ret = of_property_read_u32(np, "ti,vmbch2-threshold", &prop);
 	if (!ret)
 		board_info->vmbch2_threshold = prop;
-	else if (*chip_id == TPS65911)
-		dev_warn(&client->dev, "VMBCH2-Threshold not specified");
 
 	prop = of_property_read_bool(np, "ti,en-ck32k-xtal");
 	board_info->en_ck32k_xtal = prop;
-- 
1.7.1.1

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

[Olof Johansson]

Hi,

On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> Driver throw the warning message if dt node does not
> have the info for VMBCH-Threshold and VMBCH2-Threshold.
> These properties are optional property and hence it
> is not mandatory to have these on DT node and in this case
> it should not throw the warning message.
> It creates noise from driver as follows:
> [    0.384605] tps65910 4-002d: VMBCH-Threshold not specified
> [    0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
>
> Removing the warning message from driver.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> It seems orginal patch has been lost. Reposting it.

I still see this with 3.12-rc. Sam?

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

[Samuel Ortiz]

Hi Olof,

On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote:
> Hi,
> 
> On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> > Driver throw the warning message if dt node does not
> > have the info for VMBCH-Threshold and VMBCH2-Threshold.
> > These properties are optional property and hence it
> > is not mandatory to have these on DT node and in this case
> > it should not throw the warning message.
> > It creates noise from driver as follows:
> > [    0.384605] tps65910 4-002d: VMBCH-Threshold not specified
> > [    0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
> >
> > Removing the warning message from driver.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> > ---
> > It seems orginal patch has been lost. Reposting it.
> 
> I still see this with 3.12-rc. Sam?
I can take it through mfd-next, but do you really think it's material
for mfd-fixes ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

[Olof Johansson]

Hi,

On Thu, Oct 10, 2013 at 6:26 AM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Hi Olof,
>
> On Wed, Oct 09, 2013 at 05:51:14PM -0700, Olof Johansson wrote:
>> Hi,
>>
>> On Wed, Sep 26, 2012 at 5:48 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>> > Driver throw the warning message if dt node does not
>> > have the info for VMBCH-Threshold and VMBCH2-Threshold.
>> > These properties are optional property and hence it
>> > is not mandatory to have these on DT node and in this case
>> > it should not throw the warning message.
>> > It creates noise from driver as follows:
>> > [    0.384605] tps65910 4-002d: VMBCH-Threshold not specified
>> > [    0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
>> >
>> > Removing the warning message from driver.
>> >
>> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> > ---
>> > It seems orginal patch has been lost. Reposting it.
>>
>> I still see this with 3.12-rc. Sam?
> I can take it through mfd-next, but do you really think it's material
> for mfd-fixes ?

Oh, 3.13 is definitely fine, it'd just be good to see it not fall
between the cracks. It's a harmless warning.


-Olof

Re: [REPOST/PATCH] mfd: tps65910: remove warning during dt node parsing

[Samuel Ortiz]

Hi Laxman,

On Wed, Sep 26, 2012 at 06:18:04PM +0530, Laxman Dewangan wrote:
> Driver throw the warning message if dt node does not
> have the info for VMBCH-Threshold and VMBCH2-Threshold.
> These properties are optional property and hence it
> is not mandatory to have these on DT node and in this case
> it should not throw the warning message.
> It creates noise from driver as follows:
> [    0.384605] tps65910 4-002d: VMBCH-Threshold not specified
> [    0.384616] tps65910 4-002d: VMBCH2-Threshold not specified
> 
> Removing the warning message from driver.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> It seems orginal patch has been lost. Reposting it.
> 
>  drivers/mfd/tps65910.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
Applied and pushed to mfd-next, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/