From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mfd: tc3589x: add device tree bindings
Date: Wed, 16 Oct 2013 10:08:19 +0100 [thread overview]
Message-ID: <20131016090819.GC19112@lee--X1> (raw)
In-Reply-To: <1381871475-21543-1-git-send-email-linus.walleij@linaro.org>
I'll let the DT guys do the deep review.
Just a couple of small points from me though.
1. MFD patches have the following syntax:
mfd: <device>[-sub]: <Description> /* Note the uppercase 'D' */
> This defines the device tree bindings for the Toshiba TC3589x
> series of multi-purpose expanders. Only the stuff I can test
> is defined: GPIO and keypad. Others may implement more
> subdevices further down the road.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/tc3589x.txt | 61 +++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/tc3589x.txt
2. The binding document is normally attached to the patch which
applies the bindings, unless we've stopped doing that now.
> +
> +Example:
> +
3. You left off the example?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-10-16 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 21:11 [PATCH 1/5] mfd: tc3589x: add device tree bindings Linus Walleij
2013-10-16 9:08 ` Lee Jones [this message]
2013-10-18 9:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016090819.GC19112@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox