From: Greg KH <gregkh@linuxfoundation.org>
To: Abhishek Sudhakaran <itzurabhi@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section
Date: Sat, 23 Nov 2013 09:23:15 -0800 [thread overview]
Message-ID: <20131123172315.GB8405@kroah.com> (raw)
In-Reply-To: <1385206533-3289-1-git-send-email-itzurabhi@gmail.com>
On Sat, Nov 23, 2013 at 05:05:32PM +0530, Abhishek Sudhakaran wrote:
> Fixed a printk statement in the debug section
> where the string terminator was misplaced.
>
> Signed-off-by: Abhishek Sudhakaran <itzurabhi@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcmmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
> index 14cee3a..bc1f44c 100644
> --- a/drivers/staging/comedi/drivers/pcmmio.c
> +++ b/drivers/staging/comedi/drivers/pcmmio.c
> @@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
> #ifdef DAMMIT_ITS_BROKEN
> /* DEBUG */
> printk
> - (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
> + (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
> " data_in %02x ", byte_no, (unsigned)write_mask_byte,
> (unsigned)data_byte, offset, ioaddr, (unsigned)byte);
Did you build this patch? I think the original code is correct, and
your change will cause an error, right?
greg k-h
prev parent reply other threads:[~2013-11-23 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 11:35 [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section Abhishek Sudhakaran
2013-11-23 17:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123172315.GB8405@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=itzurabhi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox