* [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section
@ 2013-11-23 11:35 Abhishek Sudhakaran
2013-11-23 17:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Abhishek Sudhakaran @ 2013-11-23 11:35 UTC (permalink / raw)
To: abbotti; +Cc: hsweeten, devel, linux-kernel, Abhishek Sudhakaran
Fixed a printk statement in the debug section
where the string terminator was misplaced.
Signed-off-by: Abhishek Sudhakaran <itzurabhi@gmail.com>
---
drivers/staging/comedi/drivers/pcmmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
index 14cee3a..bc1f44c 100644
--- a/drivers/staging/comedi/drivers/pcmmio.c
+++ b/drivers/staging/comedi/drivers/pcmmio.c
@@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
#ifdef DAMMIT_ITS_BROKEN
/* DEBUG */
printk
- (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
+ (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
" data_in %02x ", byte_no, (unsigned)write_mask_byte,
(unsigned)data_byte, offset, ioaddr, (unsigned)byte);
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section
2013-11-23 11:35 [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section Abhishek Sudhakaran
@ 2013-11-23 17:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-11-23 17:23 UTC (permalink / raw)
To: Abhishek Sudhakaran; +Cc: abbotti, devel, linux-kernel
On Sat, Nov 23, 2013 at 05:05:32PM +0530, Abhishek Sudhakaran wrote:
> Fixed a printk statement in the debug section
> where the string terminator was misplaced.
>
> Signed-off-by: Abhishek Sudhakaran <itzurabhi@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcmmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
> index 14cee3a..bc1f44c 100644
> --- a/drivers/staging/comedi/drivers/pcmmio.c
> +++ b/drivers/staging/comedi/drivers/pcmmio.c
> @@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
> #ifdef DAMMIT_ITS_BROKEN
> /* DEBUG */
> printk
> - (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
> + (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
> " data_in %02x ", byte_no, (unsigned)write_mask_byte,
> (unsigned)data_byte, offset, ioaddr, (unsigned)byte);
Did you build this patch? I think the original code is correct, and
your change will cause an error, right?
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-23 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-23 11:35 [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section Abhishek Sudhakaran
2013-11-23 17:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox