The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Laurent Navet <laurent.navet@gmail.com>
Cc: devel@driverdev.osuosl.org, peter.p.waskiewicz.jr@intel.com,
	linux-kernel@vger.kernel.org, rashika.kheria@gmail.com,
	cruzjbishop@gmail.com
Subject: Re: [PATCH] staging: slicoss: fix possible missing iounmap
Date: Mon, 25 Nov 2013 12:28:59 -0800	[thread overview]
Message-ID: <20131125202859.GA29969@kroah.com> (raw)
In-Reply-To: <1384554607-2219-1-git-send-email-laurent.navet@gmail.com>

On Fri, Nov 15, 2013 at 11:30:07PM +0100, Laurent Navet wrote:
> if slic_card_locate failed, memmapped_ioaddr is not unmapped.
> 
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch causes a build warning to be added to the system, implying
that you didn't even test-build this patch :(

Sorry, I can't take this as-is for this obvious reason.

Please fix this up and resend.

thanks,

greg k-h

      reply	other threads:[~2013-11-25 20:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 22:30 [PATCH] staging: slicoss: fix possible missing iounmap Laurent Navet
2013-11-25 20:28 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131125202859.GA29969@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cruzjbishop@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=laurent.navet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox