* [PATCH] staging: slicoss: fix possible missing iounmap
@ 2013-11-15 22:30 Laurent Navet
2013-11-25 20:28 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Navet @ 2013-11-15 22:30 UTC (permalink / raw)
To: gregkh
Cc: peterhuewe, rashika.kheria, peter.p.waskiewicz.jr, cruzjbishop,
devel, linux-kernel, Laurent Navet
if slic_card_locate failed, memmapped_ioaddr is not unmapped.
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/staging/slicoss/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 652272b..ab7206d 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3708,7 +3708,7 @@ static int slic_entry_probe(struct pci_dev *pcidev,
err = slic_card_locate(adapter);
if (err) {
dev_err(&pcidev->dev, "cannot locate card\n");
- goto err_out_free_mmio_region;
+ goto err_out_unmap;
}
card = adapter->card;
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: slicoss: fix possible missing iounmap
2013-11-15 22:30 [PATCH] staging: slicoss: fix possible missing iounmap Laurent Navet
@ 2013-11-25 20:28 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-11-25 20:28 UTC (permalink / raw)
To: Laurent Navet
Cc: devel, peter.p.waskiewicz.jr, linux-kernel, rashika.kheria,
cruzjbishop
On Fri, Nov 15, 2013 at 11:30:07PM +0100, Laurent Navet wrote:
> if slic_card_locate failed, memmapped_ioaddr is not unmapped.
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> drivers/staging/slicoss/slicoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch causes a build warning to be added to the system, implying
that you didn't even test-build this patch :(
Sorry, I can't take this as-is for this obvious reason.
Please fix this up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-25 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 22:30 [PATCH] staging: slicoss: fix possible missing iounmap Laurent Navet
2013-11-25 20:28 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox