From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: jongman.heo@samsung.com, David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] inet: fix possible seqlock deadlocks
Date: Thu, 28 Nov 2013 19:09:14 +0100 [thread overview]
Message-ID: <20131128180914.GA24171@order.stressinduktion.org> (raw)
In-Reply-To: <1385661082.5352.34.camel@edumazet-glaptop2.roam.corp.google.com>
On Thu, Nov 28, 2013 at 09:51:22AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> In commit c9e9042994d3 ("ipv4: fix possible seqlock deadlock") I left
> another places where IP_INC_STATS_BH() were improperly used.
>
> udp_sendmsg(), ping_v4_sendmsg() and tcp_v4_connect() are called from
> process context, not from softirq context.
>
> This was detected by lockdep seqlock support.
>
> Reported-by: jongman heo <jongman.heo@samsung.com>
> Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
> Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Just got home after getting distracted with other things today and the work is
already done. Thanks, Eric! ;)
Exactly the spots I noticed this morning, so
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Should we do something about the naming? I find it rather dangerous because
they look like the _bh lock postfixes but act exactly in the opposite?
Greetings,
Hannes
next prev parent reply other threads:[~2013-11-28 18:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 4:17 3.13.0-rc1+ INFO: inconsistent lock state 허종만
2013-11-28 7:18 ` Hannes Frederic Sowa
2013-11-28 17:23 ` [PATCH] udp: fix possible seqlock deadlock Eric Dumazet
2013-11-28 17:36 ` Eric Dumazet
2013-11-28 17:51 ` [PATCH v2] inet: fix possible seqlock deadlocks Eric Dumazet
2013-11-28 18:09 ` Hannes Frederic Sowa [this message]
2013-11-29 21:38 ` David Miller
2013-11-28 19:22 ` [PATCH] inet: further fixes of " Hannes Frederic Sowa
2013-11-28 21:01 ` Eric Dumazet
2013-11-28 21:27 ` Hannes Frederic Sowa
2013-11-28 22:19 ` Hannes Frederic Sowa
2013-11-28 23:15 ` David Miller
2013-11-29 5:39 ` [PATCH] ipv6: fix possible seqlock deadlock in ip6_finish_output2 Hannes Frederic Sowa
2013-11-30 16:45 ` Eric Dumazet
2013-11-30 17:49 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-11-29 2:08 [PATCH v2] inet: fix possible seqlock deadlocks Jongman Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128180914.GA24171@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jongman.heo@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox