From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Eric Dumazet <eric.dumazet@gmail.com>,
jongman.heo@samsung.com, David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] inet: further fixes of possible seqlock deadlocks
Date: Thu, 28 Nov 2013 23:19:26 +0100 [thread overview]
Message-ID: <20131128221926.GG24171@order.stressinduktion.org> (raw)
In-Reply-To: <20131128212700.GF24171@order.stressinduktion.org>
On Thu, Nov 28, 2013 at 10:27:00PM +0100, Hannes Frederic Sowa wrote:
> > > @@ -1524,8 +1524,8 @@ int ip6_push_pending_frames(struct sock *sk)
> > > if (proto == IPPROTO_ICMPV6) {
> > > struct inet6_dev *idev = ip6_dst_idev(skb_dst(skb));
> > >
> > > - ICMP6MSGOUT_INC_STATS_BH(net, idev, icmp6_hdr(skb)->icmp6_type);
> > > - ICMP6_INC_STATS_BH(net, idev, ICMP6_MIB_OUTMSGS);
> > > + ICMP6MSGOUT_INC_STATS(net, idev, icmp6_hdr(skb)->icmp6_type);
> > > + ICMP6_INC_STATS(net, idev, ICMP6_MIB_OUTMSGS);
> >
> > I am not sure we use a seqlock for ICMP stats.
> >
> > seqlocks were used for 64bit IP stats
>
> True, atomic longs get used here in both cases.
I don't really understand why we distinguish between _BH and plain ICMP stat
calls then.
The non-_BH versions deactivate interrupts when updating the per-cpu counter.
next prev parent reply other threads:[~2013-11-28 22:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 4:17 3.13.0-rc1+ INFO: inconsistent lock state 허종만
2013-11-28 7:18 ` Hannes Frederic Sowa
2013-11-28 17:23 ` [PATCH] udp: fix possible seqlock deadlock Eric Dumazet
2013-11-28 17:36 ` Eric Dumazet
2013-11-28 17:51 ` [PATCH v2] inet: fix possible seqlock deadlocks Eric Dumazet
2013-11-28 18:09 ` Hannes Frederic Sowa
2013-11-29 21:38 ` David Miller
2013-11-28 19:22 ` [PATCH] inet: further fixes of " Hannes Frederic Sowa
2013-11-28 21:01 ` Eric Dumazet
2013-11-28 21:27 ` Hannes Frederic Sowa
2013-11-28 22:19 ` Hannes Frederic Sowa [this message]
2013-11-28 23:15 ` David Miller
2013-11-29 5:39 ` [PATCH] ipv6: fix possible seqlock deadlock in ip6_finish_output2 Hannes Frederic Sowa
2013-11-30 16:45 ` Eric Dumazet
2013-11-30 17:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128221926.GG24171@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jongman.heo@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).