[PATCH] Add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8

[PATCH] Add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8

[Michele Baldessari]

We've received multiple reports in Fedora via (BZ 907193)
that the Seagate Momentus SpinPoint M8 errors out when enabling AA:
[    2.555905] ata2.00: failed to enable AA (error_mask=0x1)
[    2.568482] ata2.00: failed to enable AA (error_mask=0x1)

Add the ATA_HORKAGE_BROKEN_FPDMA_AA for this specific harddisk.

Reported-by: Nicholas <arealityfarbetween@googlemail.com>
Signed-off-by: Michele Baldessari <michele@acksyn.org>
Tested-by: Nicholas <arealityfarbetween@googlemail.com>
---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 81a94a3..f6b0892 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4156,6 +4156,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "ST3320[68]13AS",	"SD1[5-9]",	ATA_HORKAGE_NONCQ |
 						ATA_HORKAGE_FIRMWARE_WARN },
 
+	/* Seagate Momentus SpinPoint M8 seem to have FPMDA_AA issues */
+	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
+
 	/* Blacklist entries taken from Silicon Image 3124/3132
 	   Windows driver .inf file - also several Linux problem reports */
 	{ "HTS541060G9SA00",    "MB3OC60D",     ATA_HORKAGE_NONCQ, },
-- 
1.8.4.2

Re: [PATCH] Add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8

[One Thousand Gnomes]

> Reported-by: Nicholas <arealityfarbetween@googlemail.com>
> Signed-off-by: Michele Baldessari <michele@acksyn.org>
> Tested-by: Nicholas <arealityfarbetween@googlemail.com>

Acked-by: Alan Cox <gnomes@lxorguk.ukuu.org.uk>

Going for a dig in google turns this up against multiple controllers,
multiple kernels, multiple distros..


> ---
>  drivers/ata/libata-core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 81a94a3..f6b0892 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4156,6 +4156,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "ST3320[68]13AS",	"SD1[5-9]",	ATA_HORKAGE_NONCQ |
>  						ATA_HORKAGE_FIRMWARE_WARN },
>  
> +	/* Seagate Momentus SpinPoint M8 seem to have FPMDA_AA issues */
> +	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA },
> +
>  	/* Blacklist entries taken from Silicon Image 3124/3132
>  	   Windows driver .inf file - also several Linux problem reports */
>  	{ "HTS541060G9SA00",    "MB3OC60D",     ATA_HORKAGE_NONCQ, },

Re: [PATCH] Add ATA_HORKAGE_BROKEN_FPDMA_AA quirk for Seagate Momentus SpinPoint M8

[Tejun Heo]

On Mon, Nov 25, 2013 at 07:00:14PM +0000, Michele Baldessari wrote:
> We've received multiple reports in Fedora via (BZ 907193)
> that the Seagate Momentus SpinPoint M8 errors out when enabling AA:
> [    2.555905] ata2.00: failed to enable AA (error_mask=0x1)
> [    2.568482] ata2.00: failed to enable AA (error_mask=0x1)
> 
> Add the ATA_HORKAGE_BROKEN_FPDMA_AA for this specific harddisk.
> 
> Reported-by: Nicholas <arealityfarbetween@googlemail.com>
> Signed-off-by: Michele Baldessari <michele@acksyn.org>
> Tested-by: Nicholas <arealityfarbetween@googlemail.com>

Applied to libata/for-3.13-fixes w/ stable cc'd.

Thanks!

-- 
tejun