The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [patch] mfd: max14577: cleanup an error message
@ 2013-12-04 14:07 Dan Carpenter
  2013-12-04 14:14 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-12-04 14:07 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: Lee Jones, linux-kernel, kernel-janitors

"pdata" is a NULL not an ERR_PTR so there is no use printing it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index 1337c4527028..a5e1c370c609 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -96,8 +96,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c,
 	}
 
 	if (!pdata) {
-		dev_err(&i2c->dev, "No platform data found: %ld\n",
-				PTR_ERR(pdata));
+		dev_err(&i2c->dev, "No platform data found.\n");
 		return -EINVAL;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] mfd: max14577: cleanup an error message
  2013-12-04 14:07 [patch] mfd: max14577: cleanup an error message Dan Carpenter
@ 2013-12-04 14:14 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-12-04 14:14 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Samuel Ortiz, linux-kernel, kernel-janitors

> "pdata" is a NULL not an ERR_PTR so there is no use printing it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied with the $SUBJECT line correctly capitalised.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-04 14:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-04 14:07 [patch] mfd: max14577: cleanup an error message Dan Carpenter
2013-12-04 14:14 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox