From: Mark Brown <broonie@kernel.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
grant.likely@linaro.org, rob.herring@calxeda.com,
linux-doc@vger.kernel.org, vpalatin@chromium.org,
nicolas.ferre@atmel.com, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] ARM: dts: sama5d3xcm: add the regulator device node
Date: Tue, 17 Dec 2013 12:38:18 +0000 [thread overview]
Message-ID: <20131217123818.GV3185@sirena.org.uk> (raw)
In-Reply-To: <1387258597-21866-4-git-send-email-wenyou.yang@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
On Tue, Dec 17, 2013 at 01:36:37PM +0800, Wenyou Yang wrote:
> + vcc_1v8_reg: DCDC_REG1 {
> + regulator-name = "DCDC_REG1";
The whole point of naming the regulators is to help users read kernel
diagnostic output so the should normally be named after the supply in
the schematic. If you're using the name of the supply on the PMIC you
can just omit it since that's the default anyway and it's not adding
extra information. Use something like VCC_1V8.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-17 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 5:36 [PATCH 0/3 v2] regulator: act8865: add PMIC driver Wenyou Yang
2013-12-17 5:36 ` [PATCH 1/3 v2] regulator: act8865: add PMIC act8865 driver Wenyou Yang
2013-12-17 13:06 ` Mark Brown
2013-12-18 3:11 ` Yang, Wenyou
2013-12-18 11:06 ` Mark Brown
2013-12-17 5:36 ` [PATCH 2/3 v2] regulator: act8865: add device tree binding doc Wenyou Yang
2013-12-17 12:47 ` Mark Brown
2013-12-18 3:12 ` Yang, Wenyou
2013-12-17 5:36 ` [PATCH 3/3 v2] ARM: dts: sama5d3xcm: add the regulator device node Wenyou Yang
2013-12-17 12:38 ` Mark Brown [this message]
2013-12-18 3:15 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217123818.GV3185@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=vpalatin@chromium.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox