From: Mark Brown <broonie@kernel.org>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"vpalatin@chromium.org" <vpalatin@chromium.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"plagnioj@jcrosoft.com" <plagnioj@jcrosoft.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3 v2] regulator: act8865: add PMIC act8865 driver
Date: Wed, 18 Dec 2013 11:06:31 +0000 [thread overview]
Message-ID: <20131218110631.GD28455@sirena.org.uk> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A24364172F18381@penmbx01>
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
On Wed, Dec 18, 2013 at 03:11:12AM +0000, Yang, Wenyou wrote:
> > This is the wrong type for a voltage table but it looks like it
> > shouldn't be a voltage table at all - this looks like it should be
> > mapped as linear ranges.
> Change it, using unsigned int.
> It is not linear, can't be mapped as linear range. so using voltage table.
No, linear ranges with a plural - look at regulator_map_voltage_linear_range.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-18 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 5:36 [PATCH 0/3 v2] regulator: act8865: add PMIC driver Wenyou Yang
2013-12-17 5:36 ` [PATCH 1/3 v2] regulator: act8865: add PMIC act8865 driver Wenyou Yang
2013-12-17 13:06 ` Mark Brown
2013-12-18 3:11 ` Yang, Wenyou
2013-12-18 11:06 ` Mark Brown [this message]
2013-12-17 5:36 ` [PATCH 2/3 v2] regulator: act8865: add device tree binding doc Wenyou Yang
2013-12-17 12:47 ` Mark Brown
2013-12-18 3:12 ` Yang, Wenyou
2013-12-17 5:36 ` [PATCH 3/3 v2] ARM: dts: sama5d3xcm: add the regulator device node Wenyou Yang
2013-12-17 12:38 ` Mark Brown
2013-12-18 3:15 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218110631.GD28455@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=Wenyou.Yang@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox