* [PATCH -next] mfd: rtsx: fix sparse non static symbol warning
@ 2013-12-20 2:50 Wei Yongjun
2013-12-20 14:04 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-12-20 2:50 UTC (permalink / raw)
To: sameo, lee.jones, micky_ching; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warning:
drivers/mfd/rtl8411.c:473:6: warning:
symbol 'rtl8411_init_common_params' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mfd/rtl8411.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rtl8411.c b/drivers/mfd/rtl8411.c
index ada38ad..fdd34c8 100644
--- a/drivers/mfd/rtl8411.c
+++ b/drivers/mfd/rtl8411.c
@@ -470,7 +470,7 @@ static const u32 rtl8411b_qfn48_ms_pull_ctl_disable_tbl[] = {
0,
};
-void rtl8411_init_common_params(struct rtsx_pcr *pcr)
+static void rtl8411_init_common_params(struct rtsx_pcr *pcr)
{
pcr->extra_caps = EXTRA_CAPS_SD_SDR50 | EXTRA_CAPS_SD_SDR104;
pcr->num_slots = 2;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] mfd: rtsx: fix sparse non static symbol warning
2013-12-20 2:50 [PATCH -next] mfd: rtsx: fix sparse non static symbol warning Wei Yongjun
@ 2013-12-20 14:04 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-12-20 14:04 UTC (permalink / raw)
To: Wei Yongjun; +Cc: sameo, micky_ching, yongjun_wei, linux-kernel
On Fri, 20 Dec 2013, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
>
> drivers/mfd/rtl8411.c:473:6: warning:
> symbol 'rtl8411_init_common_params' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mfd/rtl8411.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-20 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 2:50 [PATCH -next] mfd: rtsx: fix sparse non static symbol warning Wei Yongjun
2013-12-20 14:04 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox