* [PATCH] staging: cxt1e1: remove unnecessary function, VMETRO_TRACE
@ 2014-02-04 8:35 SeongJae Park
0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2014-02-04 8:35 UTC (permalink / raw)
To: gregkh, dulshani.gunawardhana89, shaun, lisa, sima.baymani,
dan.carpenter
Cc: deve, linux-kernel, SeongJae Park
VMETRO_TRACE isn't called from anywhere. So delete it.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/cxt1e1/functions.c | 9 ---------
drivers/staging/cxt1e1/pmcc4.h | 1 -
2 files changed, 10 deletions(-)
diff --git a/drivers/staging/cxt1e1/functions.c b/drivers/staging/cxt1e1/functions.c
index 95218e2..f5ce852 100644
--- a/drivers/staging/cxt1e1/functions.c
+++ b/drivers/staging/cxt1e1/functions.c
@@ -263,15 +263,6 @@ void sd_recv_consume(void *token, size_t len, void *user)
extern ci_t *CI; /* dummy pointer to board ZERO's data */
void
-VMETRO_TRACE (void *x)
-{
- u_int32_t y = (u_int32_t) x;
-
- pci_write_32 ((u_int32_t *) &CI->cpldbase->leds, y);
-}
-
-
-void
VMETRO_TRIGGER (ci_t *ci, int x)
{
struct s_comet_reg *comet;
diff --git a/drivers/staging/cxt1e1/pmcc4.h b/drivers/staging/cxt1e1/pmcc4.h
index 003eb86..b4b5e5a 100644
--- a/drivers/staging/cxt1e1/pmcc4.h
+++ b/drivers/staging/cxt1e1/pmcc4.h
@@ -96,7 +96,6 @@ void sbeid_set_bdtype (ci_t *ci);
void sbeid_set_hdwbid (ci_t *ci);
u_int32_t sbeCrc (u_int8_t *, u_int32_t, u_int32_t, u_int32_t *);
-void VMETRO_TRACE (void *); /* put data into 8 LEDs */
void VMETRO_TRIGGER (ci_t *, int); /* Note: int = 0(default)
* thru 15 */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] staging: cxt1e1: remove unnecessary function, VMETRO_TRACE
@ 2014-02-04 8:36 SeongJae Park
2014-02-04 8:47 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: SeongJae Park @ 2014-02-04 8:36 UTC (permalink / raw)
To: gregkh, dulshani.gunawardhana89, shaun, lisa, sima.baymani,
dan.carpenter
Cc: devel, linux-kernel, SeongJae Park
VMETRO_TRACE isn't called from anywhere. So delete it.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/staging/cxt1e1/functions.c | 9 ---------
drivers/staging/cxt1e1/pmcc4.h | 1 -
2 files changed, 10 deletions(-)
diff --git a/drivers/staging/cxt1e1/functions.c b/drivers/staging/cxt1e1/functions.c
index 95218e2..f5ce852 100644
--- a/drivers/staging/cxt1e1/functions.c
+++ b/drivers/staging/cxt1e1/functions.c
@@ -263,15 +263,6 @@ void sd_recv_consume(void *token, size_t len, void *user)
extern ci_t *CI; /* dummy pointer to board ZERO's data */
void
-VMETRO_TRACE (void *x)
-{
- u_int32_t y = (u_int32_t) x;
-
- pci_write_32 ((u_int32_t *) &CI->cpldbase->leds, y);
-}
-
-
-void
VMETRO_TRIGGER (ci_t *ci, int x)
{
struct s_comet_reg *comet;
diff --git a/drivers/staging/cxt1e1/pmcc4.h b/drivers/staging/cxt1e1/pmcc4.h
index 003eb86..b4b5e5a 100644
--- a/drivers/staging/cxt1e1/pmcc4.h
+++ b/drivers/staging/cxt1e1/pmcc4.h
@@ -96,7 +96,6 @@ void sbeid_set_bdtype (ci_t *ci);
void sbeid_set_hdwbid (ci_t *ci);
u_int32_t sbeCrc (u_int8_t *, u_int32_t, u_int32_t, u_int32_t *);
-void VMETRO_TRACE (void *); /* put data into 8 LEDs */
void VMETRO_TRIGGER (ci_t *, int); /* Note: int = 0(default)
* thru 15 */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: cxt1e1: remove unnecessary function, VMETRO_TRACE
2014-02-04 8:36 [PATCH] staging: cxt1e1: remove unnecessary function, VMETRO_TRACE SeongJae Park
@ 2014-02-04 8:47 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-02-04 8:47 UTC (permalink / raw)
To: SeongJae Park
Cc: gregkh, dulshani.gunawardhana89, shaun, lisa, sima.baymani, devel,
linux-kernel
On Tue, Feb 04, 2014 at 05:36:39PM +0900, SeongJae Park wrote:
> VMETRO_TRACE isn't called from anywhere. So delete it.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-04 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 8:36 [PATCH] staging: cxt1e1: remove unnecessary function, VMETRO_TRACE SeongJae Park
2014-02-04 8:47 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2014-02-04 8:35 SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox