* [PATCH] drivers/mfd: fix pointer-integer size mismatch warnings
@ 2014-02-04 6:42 SeongJae Park
2014-02-04 9:03 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: SeongJae Park @ 2014-02-04 6:42 UTC (permalink / raw)
To: sameo, lee.jones; +Cc: linux-kernel, patches, SeongJae Park
Fix the pointer-integer size mismatch warnings below:
drivers/mfd/wm8994-core.c: In function ‘wm8994_i2c_probe’:
mfd/wm8994-core.c:639:19: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
wm8994->type = (int)of_id->data;
^
drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
drivers/mfd/max8997.c:173:10: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
return (int)match->data;
^
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/mfd/max8997.c | 2 +-
drivers/mfd/wm8994-core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
index be88a3b..768bcb1 100644
--- a/drivers/mfd/max8997.c
+++ b/drivers/mfd/max8997.c
@@ -170,7 +170,7 @@ static inline int max8997_i2c_get_driver_data(struct i2c_client *i2c,
if (IS_ENABLED(CONFIG_OF) && i2c->dev.of_node) {
const struct of_device_id *match;
match = of_match_node(max8997_pmic_dt_match, i2c->dev.of_node);
- return (int)match->data;
+ return (int)(long)match->data;
}
return (int)id->driver_data;
}
diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
index ba04f1b..1b25335 100644
--- a/drivers/mfd/wm8994-core.c
+++ b/drivers/mfd/wm8994-core.c
@@ -636,7 +636,7 @@ static int wm8994_i2c_probe(struct i2c_client *i2c,
if (i2c->dev.of_node) {
of_id = of_match_device(wm8994_of_match, &i2c->dev);
if (of_id)
- wm8994->type = (int)of_id->data;
+ wm8994->type = (int)(long)of_id->data;
} else {
wm8994->type = id->driver_data;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/mfd: fix pointer-integer size mismatch warnings
2014-02-04 6:42 [PATCH] drivers/mfd: fix pointer-integer size mismatch warnings SeongJae Park
@ 2014-02-04 9:03 ` Lee Jones
2014-02-04 9:07 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2014-02-04 9:03 UTC (permalink / raw)
To: SeongJae Park; +Cc: sameo, linux-kernel, patches
> Fix the pointer-integer size mismatch warnings below:
> drivers/mfd/wm8994-core.c: In function ‘wm8994_i2c_probe’:
> mfd/wm8994-core.c:639:19: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
> wm8994->type = (int)of_id->data;
> ^
> drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
> drivers/mfd/max8997.c:173:10: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
> return (int)match->data;
> ^
Already fixed:
https://lkml.org/lkml/2014/1/23/309
https://lkml.org/lkml/2014/1/23/326
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/mfd: fix pointer-integer size mismatch warnings
2014-02-04 9:03 ` Lee Jones
@ 2014-02-04 9:07 ` SeongJae Park
0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2014-02-04 9:07 UTC (permalink / raw)
To: Lee Jones; +Cc: sameo, linux-kernel@vger.kernel.org, patches
On Tue, Feb 4, 2014 at 6:03 PM, Lee Jones <lee.jones@linaro.org> wrote:
>> Fix the pointer-integer size mismatch warnings below:
>> drivers/mfd/wm8994-core.c: In function ‘wm8994_i2c_probe’:
>> mfd/wm8994-core.c:639:19: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>> wm8994->type = (int)of_id->data;
>> ^
>> drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
>> drivers/mfd/max8997.c:173:10: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>> return (int)match->data;
>> ^
>
> Already fixed:
> https://lkml.org/lkml/2014/1/23/309
> https://lkml.org/lkml/2014/1/23/326
Oops, sorry, didn't check that(I checked only the -next tree).
Thank you for let me know.
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-04 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 6:42 [PATCH] drivers/mfd: fix pointer-integer size mismatch warnings SeongJae Park
2014-02-04 9:03 ` Lee Jones
2014-02-04 9:07 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox