From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
linaro-kernel@lists.linaro.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] mfd: wm5102: Mark register 0x19 readable
Date: Mon, 10 Mar 2014 16:38:11 +0000 [thread overview]
Message-ID: <20140310163811.GA16697@lee--X1> (raw)
In-Reply-To: <1394468977-23149-1-git-send-email-broonie@kernel.org>
> From: Mark Brown <broonie@linaro.org>
>
> During init the core checks if the wm5102 has finished starting by reading
> register 0x19 and looking at the value. This read always fails since this
> is not a readable register, mark it as being one.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/mfd/wm5102-tables.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
> index f4668d39e542..07f024fd4ded 100644
> --- a/drivers/mfd/wm5102-tables.c
> +++ b/drivers/mfd/wm5102-tables.c
> @@ -1016,6 +1016,7 @@ static bool wm5102_readable_register(struct device *dev, unsigned int reg)
> case ARIZONA_WRITE_SEQUENCER_CTRL_0:
> case ARIZONA_WRITE_SEQUENCER_CTRL_1:
> case ARIZONA_WRITE_SEQUENCER_CTRL_2:
> + case 0x19:
Can we have a #define for these please?
> case ARIZONA_WRITE_SEQUENCER_PROM:
> case ARIZONA_TONE_GENERATOR_1:
> case ARIZONA_TONE_GENERATOR_2:
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-10 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 16:29 [PATCH] mfd: wm5102: Mark register 0x19 readable Mark Brown
2014-03-10 16:38 ` Lee Jones [this message]
2014-03-10 16:49 ` Mark Brown
2014-03-10 17:05 ` Charles Keepax
2014-03-10 17:12 ` Mark Brown
2014-03-10 17:17 ` Lars-Peter Clausen
2014-03-10 17:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310163811.GA16697@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox