From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>,
patches@opensource.wolfsonmicro.com,
Samuel Ortiz <sameo@linux.intel.com>,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: wm5102: Mark register 0x19 readable
Date: Mon, 10 Mar 2014 17:29:47 +0000 [thread overview]
Message-ID: <20140310172947.GU28112@sirena.org.uk> (raw)
In-Reply-To: <531DF3A2.80504@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Mon, Mar 10, 2014 at 06:17:22PM +0100, Lars-Peter Clausen wrote:
> On 03/10/2014 06:05 PM, Charles Keepax wrote:
> >WRITE_SEQUENCER_CTRL_3, seems we should add that in since it is
> >required for that 5102 boot stuff. Slightly confused as to how
> >that ever worked without the register being readable, but guess
> >it has been a while since I have fired up 5102 on mainline.
> Presumably this change triggered it:
> http://git.kernel.org/cgit/linux/kernel/git/broonie/regmap.git/commit/?h=topic/core&id=d4807ad2c4c0e17b6f00e3be9492c81de0804f40
Indeed. Now that I think about it there's another bug lying underneath
too - the register isn't marked as volatile so it'll only actually be
being read on first read. For some reason that check is only done on
probe so it's got no impact but it seems it's asking for future
breakage.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-03-10 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 16:29 [PATCH] mfd: wm5102: Mark register 0x19 readable Mark Brown
2014-03-10 16:38 ` Lee Jones
2014-03-10 16:49 ` Mark Brown
2014-03-10 17:05 ` Charles Keepax
2014-03-10 17:12 ` Mark Brown
2014-03-10 17:17 ` Lars-Peter Clausen
2014-03-10 17:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310172947.GU28112@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox