From: Tejun Heo <tj@kernel.org>
To: Roman Peniaev <r.peniaev@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write
Date: Fri, 14 Mar 2014 10:20:36 -0400 [thread overview]
Message-ID: <20140314142036.GI12613@htj.dyndns.org> (raw)
In-Reply-To: <CACZ9PQWtHJh6j_bKwB-HF4h3rU3813AN2qUibkCs7tmXUrLJoQ@mail.gmail.com>
On Fri, Mar 14, 2014 at 11:17:56PM +0900, Roman Peniaev wrote:
> No, no. Not device does not support flush, filesystem does not care about flush.
> (take any old school, e.g. ext2)
>
> We did some write, and then we did fsync.
> But filesystem does not support REQ_FLUSH/FUA so block device will never
> get the checkpoint where it should really flush everything.
>
> So, fsync will not guarantee any integrity in that case.
Oh, no idea. Fix the filesystem to support REQ_FLUSH? :)
--
tejun
next prev parent reply other threads:[~2014-03-14 14:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 2:54 [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write Roman Pen
2014-02-18 23:59 ` Andrew Morton
2014-02-19 1:38 ` Roman Peniaev
2014-03-12 14:29 ` Roman Peniaev
2014-03-13 20:01 ` Jan Kara
2014-03-13 21:34 ` Andrew Morton
2014-03-14 13:07 ` Tejun Heo
2014-03-14 14:07 ` Roman Peniaev
2014-03-14 14:11 ` Tejun Heo
2014-03-14 14:15 ` Jan Kara
2014-03-14 14:23 ` Roman Peniaev
2014-03-14 14:52 ` Jan Kara
2014-03-14 14:54 ` Tejun Heo
2014-03-14 15:08 ` Jan Kara
2014-03-15 9:09 ` Christoph Hellwig
2014-03-14 14:17 ` Roman Peniaev
2014-03-14 14:20 ` Tejun Heo [this message]
2014-03-14 14:29 ` Roman Peniaev
2014-03-14 15:36 ` Roman Peniaev
2014-03-13 20:21 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314142036.GI12613@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.peniaev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox