From: Jan Kara <jack@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Roman Peniaev <r.peniaev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write
Date: Fri, 14 Mar 2014 16:08:50 +0100 [thread overview]
Message-ID: <20140314150850.GA5175@quack.suse.cz> (raw)
In-Reply-To: <20140314145430.GL12613@htj.dyndns.org>
On Fri 14-03-14 10:54:30, Tejun Heo wrote:
> On Fri, Mar 14, 2014 at 03:52:15PM +0100, Jan Kara wrote:
> > Well, for ext2, you can use ext4 kernel driver which takes care of
> > REQ_FLUSH properly. For fat, you'll need to fix the fs...
>
> This is a bit surprising tho. Were we always like this? We never had
> even stupid "flush down everything and sync"? Or is this something we
> broke while morphing flush implementation several times in the past
> years?
It has been always like this. We could add some sending of REQ_FLUSH into
generic code - like generic_file_fsync() and some similar helper for
->sync_fs(). Just someone has to do it...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-03-14 15:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 2:54 [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write Roman Pen
2014-02-18 23:59 ` Andrew Morton
2014-02-19 1:38 ` Roman Peniaev
2014-03-12 14:29 ` Roman Peniaev
2014-03-13 20:01 ` Jan Kara
2014-03-13 21:34 ` Andrew Morton
2014-03-14 13:07 ` Tejun Heo
2014-03-14 14:07 ` Roman Peniaev
2014-03-14 14:11 ` Tejun Heo
2014-03-14 14:15 ` Jan Kara
2014-03-14 14:23 ` Roman Peniaev
2014-03-14 14:52 ` Jan Kara
2014-03-14 14:54 ` Tejun Heo
2014-03-14 15:08 ` Jan Kara [this message]
2014-03-15 9:09 ` Christoph Hellwig
2014-03-14 14:17 ` Roman Peniaev
2014-03-14 14:20 ` Tejun Heo
2014-03-14 14:29 ` Roman Peniaev
2014-03-14 15:36 ` Roman Peniaev
2014-03-13 20:21 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314150850.GA5175@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.peniaev@gmail.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox