From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure
Date: Wed, 19 Mar 2014 08:37:18 +0000 [thread overview]
Message-ID: <20140319083718.GA31687@lee--X1> (raw)
In-Reply-To: <CAK9yfHx=3KR0WyrtmZXbYJ3MXM9vAsCzh=EKORfiifzhL2Ud8Q@mail.gmail.com>
> On 18 March 2014 18:27, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> > Dummy I2C device allocated in sec_pmic_probe() leaked if
> > devm_regmap_init_i2c() failed. Unregister it before returning from
> > probe.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Looks good.
> Reviewed-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied with Sachin's Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-03-19 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 12:57 [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure Krzysztof Kozlowski
2014-03-19 3:46 ` Sachin Kamat
2014-03-19 8:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319083718.GA31687@lee--X1 \
--to=lee.jones@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox