From: Josh Triplett <josh@joshtriplett.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: gregkh@linuxfoundation.org, teobaluta@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: fix pointer and return statement's syntax
Date: Wed, 9 Apr 2014 02:26:39 -0700 [thread overview]
Message-ID: <20140409092639.GA6733@leaf> (raw)
In-Reply-To: <1397028355-28063-1-git-send-email-martink@posteo.de>
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> index 0dc5ae4..e6257b3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> @@ -180,7 +180,7 @@ static inline int ieee80211_put_snap(u8 *data, u16 h_proto)
> int ieee80211_encrypt_fragment(struct ieee80211_device *ieee,
> struct sk_buff *frag, int hdr_len)
> {
> - struct ieee80211_crypt_data* crypt = ieee->crypt[ieee->tx_keyidx];
> + struct ieee80211_crypt_data *crypt = ieee->crypt[ieee->tx_keyidx];
> int res;
>
> /*
> @@ -285,7 +285,7 @@ static int ieee80211_classify(struct sk_buff *skb,
>
> if (!network->QoS_Enable) {
> skb->priority = 0;
> - return(wme_UP);
> + return wme_UP;
> }
>
> if (eh->ether_type == __constant_htons(ETHERTYPE_IP)) {
> @@ -304,7 +304,7 @@ static int ieee80211_classify(struct sk_buff *skb,
> }
>
> skb->priority = wme_UP;
> - return(wme_UP);
> + return wme_UP;
> }
>
> /* SKBs are added to the ieee->tx_queue. */
> --
> 1.7.10.4
>
prev parent reply other threads:[~2014-04-09 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 7:25 [PATCH] staging: rtl8187se: fix pointer and return statement's syntax Martin Kepplinger
2014-04-09 9:26 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409092639.GA6733@leaf \
--to=josh@joshtriplett.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox