* [PATCH] staging: rtl8187se: fix pointer and return statement's syntax
@ 2014-04-09 7:25 Martin Kepplinger
2014-04-09 9:26 ` Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2014-04-09 7:25 UTC (permalink / raw)
To: gregkh; +Cc: teobaluta, josh, devel, linux-kernel, Martin Kepplinger
Use the common kernel coding style.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
noise from the eudyptula challenge. applies to next-20140408 as well as
linus' current tree.
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
index 0dc5ae4..e6257b3 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
@@ -180,7 +180,7 @@ static inline int ieee80211_put_snap(u8 *data, u16 h_proto)
int ieee80211_encrypt_fragment(struct ieee80211_device *ieee,
struct sk_buff *frag, int hdr_len)
{
- struct ieee80211_crypt_data* crypt = ieee->crypt[ieee->tx_keyidx];
+ struct ieee80211_crypt_data *crypt = ieee->crypt[ieee->tx_keyidx];
int res;
/*
@@ -285,7 +285,7 @@ static int ieee80211_classify(struct sk_buff *skb,
if (!network->QoS_Enable) {
skb->priority = 0;
- return(wme_UP);
+ return wme_UP;
}
if (eh->ether_type == __constant_htons(ETHERTYPE_IP)) {
@@ -304,7 +304,7 @@ static int ieee80211_classify(struct sk_buff *skb,
}
skb->priority = wme_UP;
- return(wme_UP);
+ return wme_UP;
}
/* SKBs are added to the ieee->tx_queue. */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rtl8187se: fix pointer and return statement's syntax
2014-04-09 7:25 [PATCH] staging: rtl8187se: fix pointer and return statement's syntax Martin Kepplinger
@ 2014-04-09 9:26 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2014-04-09 9:26 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: gregkh, teobaluta, devel, linux-kernel
On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> index 0dc5ae4..e6257b3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> @@ -180,7 +180,7 @@ static inline int ieee80211_put_snap(u8 *data, u16 h_proto)
> int ieee80211_encrypt_fragment(struct ieee80211_device *ieee,
> struct sk_buff *frag, int hdr_len)
> {
> - struct ieee80211_crypt_data* crypt = ieee->crypt[ieee->tx_keyidx];
> + struct ieee80211_crypt_data *crypt = ieee->crypt[ieee->tx_keyidx];
> int res;
>
> /*
> @@ -285,7 +285,7 @@ static int ieee80211_classify(struct sk_buff *skb,
>
> if (!network->QoS_Enable) {
> skb->priority = 0;
> - return(wme_UP);
> + return wme_UP;
> }
>
> if (eh->ether_type == __constant_htons(ETHERTYPE_IP)) {
> @@ -304,7 +304,7 @@ static int ieee80211_classify(struct sk_buff *skb,
> }
>
> skb->priority = wme_UP;
> - return(wme_UP);
> + return wme_UP;
> }
>
> /* SKBs are added to the ieee->tx_queue. */
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-09 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 7:25 [PATCH] staging: rtl8187se: fix pointer and return statement's syntax Martin Kepplinger
2014-04-09 9:26 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox