[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

[Richard Leitner]

Removed not needed spaces and fixed too long lines

PS: this is an exercise to get into the "patch submitting workflow"

Signed-off-by: Richard Leitner <me@g0hl1n.net>
---
  drivers/staging/comedi/drivers/adl_pci9118.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c 
b/drivers/staging/comedi/drivers/adl_pci9118.c
index 3cfa175..d028d6b 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -96,7 +96,7 @@ Configuration options:
  				 * correct channel number on every 12 bit sample
  				 */

-#define IORANGE_9118 	64	/* I hope */
+#define IORANGE_9118	64	/* I hope */
  #define PCI9118_CHANLEN	255	/*
  				 * len of chanlist, some source say 256,
  				 * but reality looks like 255 :-(
@@ -356,7 +356,7 @@ struct pci9118_private {
  	unsigned int ai_data_len;
  	unsigned short ao_data[2];		/* data output buffer */
  	unsigned int ai_scans;			/* number of scans to do */
-	char dma_doublebuf;			/* we can use double buffering */
+	char dma_doublebuf;			/* we can use double buffering*/
  	unsigned int dma_actbuf;		/* which buffer is used now */
  	unsigned short *dmabuf_virt[2];		/*
  						 * pointers to begin of
@@ -383,7 +383,7 @@ struct pci9118_private {
  						 * users(0-AI, 1-AO, 2-DI, 3-DO)
  						 */
  	unsigned int cnt0_divisor;		/* actual CNT0 divisor */
-	void (*int_ai_func) (struct comedi_device *, struct comedi_subdevice 
*,
+	void (*int_ai_func)(struct comedi_device *, struct comedi_subdevice *,
  		unsigned short,
  		unsigned int,
  		unsigned short);	/*
@@ -1045,7 +1045,7 @@ static void interrupt_pci9118_ai_dma(struct 
comedi_device *dev,
  		move_block_from_dma(dev, s,
  				    devpriv->dmabuf_virt[devpriv->dma_actbuf],
  				    samplesinbuf);
-		m = m - sampls;		/* m= how many samples was transferred */
+		m = m - sampls;		/* m=how many samples was transferred */
  	}

  	if (!devpriv->ai_neverending) {
-- 
1.7.10.4

Re: [PATCH] staging: comedi: adl_pci9118: fix whitespace issues

[Dan Carpenter]

On Wed, Apr 09, 2014 at 01:35:37PM +0200, Richard Leitner wrote:
> Removed not needed spaces and fixed too long lines
> 
> PS: this is an exercise to get into the "patch submitting workflow"

Put the "PS" after the --- cut off.  Otherwise it's not a PS but a part
of the permanent changelog.

> 
> Signed-off-by: Richard Leitner <me@g0hl1n.net>
> ---
>  drivers/staging/comedi/drivers/adl_pci9118.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
> b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 3cfa175..d028d6b 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -96,7 +96,7 @@ Configuration options:
>  				 * correct channel number on every 12 bit sample
>  				 */
> 
> -#define IORANGE_9118		64	/* I hope */
> +#define IORANGE_9118	64	/* I hope */
>  #define PCI9118_CHANLEN	255	/*
>  				 * len of chanlist, some source say 256,
>  				 * but reality looks like 255 :-(
> @@ -356,7 +356,7 @@ struct pci9118_private {
>  	unsigned int ai_data_len;
>  	unsigned short ao_data[2];		/* data output buffer */
>  	unsigned int ai_scans;			/* number of scans to do */
> -	char dma_doublebuf;			/* we can use double buffering */
> +	char dma_doublebuf;			/* we can use double buffering*/

Just leave this one as-is.  The original was better for human beings.
Human beings are more important than checkpatch.pl.

>  	unsigned int dma_actbuf;		/* which buffer is used now */
>  	unsigned short *dmabuf_virt[2];		/*
>  						 * pointers to begin of
> @@ -383,7 +383,7 @@ struct pci9118_private {
>  						 * users(0-AI, 1-AO, 2-DI, 3-DO)
>  						 */
>  	unsigned int cnt0_divisor;		/* actual CNT0 divisor */
> -	void (*int_ai_func) (struct comedi_device *, struct
> comedi_subdevice *,
> +	void (*int_ai_func)(struct comedi_device *, struct comedi_subdevice *,

You're email is line wrapping patches so they won't apply.  Read
Documentation/email-clients.txt or use git send-email.

regards,
dan carpenter

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

[Richard Leitner]

Removed not needed spaces and fixed too long lines

Signed-off-by: Richard Leitner <me@g0hl1n.net>
---
 drivers/staging/comedi/drivers/adl_pci9118.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
index 3cfa175..b6abef6 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -96,7 +96,7 @@ Configuration options:
 				 * correct channel number on every 12 bit sample
 				 */
 
-#define IORANGE_9118 	64	/* I hope */
+#define IORANGE_9118	64	/* I hope */
 #define PCI9118_CHANLEN	255	/*
 				 * len of chanlist, some source say 256,
 				 * but reality looks like 255 :-(
@@ -383,7 +383,7 @@ struct pci9118_private {
 						 * users(0-AI, 1-AO, 2-DI, 3-DO)
 						 */
 	unsigned int cnt0_divisor;		/* actual CNT0 divisor */
-	void (*int_ai_func) (struct comedi_device *, struct comedi_subdevice *,
+	void (*int_ai_func)(struct comedi_device *, struct comedi_subdevice *,
 		unsigned short,
 		unsigned int,
 		unsigned short);	/*
@@ -1045,7 +1045,7 @@ static void interrupt_pci9118_ai_dma(struct comedi_device *dev,
 		move_block_from_dma(dev, s,
 				    devpriv->dmabuf_virt[devpriv->dma_actbuf],
 				    samplesinbuf);
-		m = m - sampls;		/* m= how many samples was transferred */
+		m = m - sampls;		/* m=how many samples was transferred */
 	}
 
 	if (!devpriv->ai_neverending) {
-- 
1.9.1