* [PATCH] staging: dgrp: Fixed coding style
@ 2014-04-16 0:54 Thomas Tanaka
2014-04-16 7:44 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Tanaka @ 2014-04-16 0:54 UTC (permalink / raw)
To: gregkh
Cc: jg1.han, akpm, keescook, peter.p.waskiewicz.jr, bernat.ada,
thomas.tanaka, devel, linux-kernel
Fixed line width > 80
Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com>
---
drivers/staging/dgrp/dgrp_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging/dgrp/dgrp_sysfs.c
index 2f9345f..93803e0c 100644
--- a/drivers/staging/dgrp/dgrp_sysfs.c
+++ b/drivers/staging/dgrp/dgrp_sysfs.c
@@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
&dgrp_global_settings_attribute_group);
if (ret) {
- pr_alert("%s: failed to create sysfs global settings device attributes.\n",
- __func__);
+ pr_alert("%s: failed to create sysfs global settings device
+ attributes.\n", __func__);
goto err_dev1;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: dgrp: Fixed coding style
2014-04-16 0:54 [PATCH] staging: dgrp: Fixed coding style Thomas Tanaka
@ 2014-04-16 7:44 ` Dan Carpenter
2014-04-16 7:54 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-04-16 7:44 UTC (permalink / raw)
To: Thomas Tanaka
Cc: gregkh, devel, bernat.ada, jg1.han, keescook,
peter.p.waskiewicz.jr, linux-kernel, akpm
On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote:
> Fixed line width > 80
>
> Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com>
> ---
> drivers/staging/dgrp/dgrp_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging/dgrp/dgrp_sysfs.c
> index 2f9345f..93803e0c 100644
> --- a/drivers/staging/dgrp/dgrp_sysfs.c
> +++ b/drivers/staging/dgrp/dgrp_sysfs.c
> @@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
> ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
> &dgrp_global_settings_attribute_group);
> if (ret) {
> - pr_alert("%s: failed to create sysfs global settings device attributes.\n",
> - __func__);
> + pr_alert("%s: failed to create sysfs global settings device
> + attributes.\n", __func__);
The original was fine. It doesn't cause a checkpatch.pl warning. The
new one is buggy and won't print the correct text.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: dgrp: Fixed coding style
2014-04-16 7:44 ` Dan Carpenter
@ 2014-04-16 7:54 ` Jingoo Han
0 siblings, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2014-04-16 7:54 UTC (permalink / raw)
To: 'Dan Carpenter', 'Thomas Tanaka'
Cc: gregkh, devel, bernat.ada, keescook, peter.p.waskiewicz.jr,
linux-kernel, akpm, 'Jingoo Han'
On Wednesday, April 16, 2014 4:44 PM, Dan Carpenter wrote:
> On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote:
> > Fixed line width > 80
> >
> > Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com>
> > ---
> > drivers/staging/dgrp/dgrp_sysfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging/dgrp/dgrp_sysfs.c
> > index 2f9345f..93803e0c 100644
> > --- a/drivers/staging/dgrp/dgrp_sysfs.c
> > +++ b/drivers/staging/dgrp/dgrp_sysfs.c
> > @@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
> > ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
> > &dgrp_global_settings_attribute_group);
> > if (ret) {
> > - pr_alert("%s: failed to create sysfs global settings device attributes.\n",
> > - __func__);
> > + pr_alert("%s: failed to create sysfs global settings device
> > + attributes.\n", __func__);
>
> The original was fine. It doesn't cause a checkpatch.pl warning. The
> new one is buggy and won't print the correct text.
Yes, right. In this case, it prints some tabs between 'device'
and 'attributes.' So, this patch should be NAKed.
Best regards,
Jingoo Han
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-16 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-16 0:54 [PATCH] staging: dgrp: Fixed coding style Thomas Tanaka
2014-04-16 7:44 ` Dan Carpenter
2014-04-16 7:54 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox