* [patch resend] agp: info leak in agpioc_info_wrap()
@ 2014-05-03 20:27 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-05-03 20:27 UTC (permalink / raw)
To: David Airlie, Andrew Morton; +Cc: linux-kernel, kernel-janitors
On 64 bit systems the agp_info struct has a 4 byte hole between
->agp_mode and ->aper_base. We need to clear it to avoid disclosing
stack information to userspace.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I sent this before on 13 Apr 2013 and a reminder on 31 May 2013 so now
I'm going to try sneak it in through the akpm tree.
diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
index 8121b4c..b297033 100644
--- a/drivers/char/agp/frontend.c
+++ b/drivers/char/agp/frontend.c
@@ -730,6 +730,7 @@ static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)
agp_copy_info(agp_bridge, &kerninfo);
+ memset(&userinfo, 0, sizeof(userinfo));
userinfo.version.major = kerninfo.version.major;
userinfo.version.minor = kerninfo.version.minor;
userinfo.bridge_id = kerninfo.device->vendor |
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-05-03 20:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-03 20:27 [patch resend] agp: info leak in agpioc_info_wrap() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox