From: Mark Brown <broonie@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arvind Chauhan <arvind.chauhan@arm.com>,
Eduardo Valentin <edubezval@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR
Date: Tue, 3 Jun 2014 16:48:54 +0100 [thread overview]
Message-ID: <20140603154854.GG31751@sirena.org.uk> (raw)
In-Reply-To: <CAKohpo=VLCf2nz1WsL-iGw6BWwpmqZ+8JwGFFHFFtjZyAS9LrA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On Tue, Jun 03, 2014 at 08:55:25PM +0530, Viresh Kumar wrote:
> On 3 June 2014 20:23, Mark Brown <broonie@kernel.org> wrote:
> > Well, we would need to look at what the drivers were doing and figure
> > out something sensible - it really depends why they're trying to set the
> > regulator and what would happen if it doesn't work.
> For example, few cpufreq drivers are calling it during frequency
> transition and are checking return value as well.. And fail if it failed.
> One way out might be checking if pointer to regulator is valid or not
> and only call it if pointer is not NULL..
No, as I've explained repeatedly NULL is a perfectly valid regulator and
that's not going to work reliably. As I've previously requested please
think about what happens to cpufreq if we fail to ramp voltages.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-03 15:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 12:07 [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR Viresh Kumar
2014-05-27 12:07 ` [PATCH V2 2/2] cpufreq: cpufreq-cpu0: remove dependency on THERMAL and REGULATOR Viresh Kumar
2014-05-27 19:29 ` [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR Mark Brown
2014-05-27 23:12 ` Rafael J. Wysocki
2014-05-28 17:37 ` Mark Brown
2014-05-28 16:29 ` Viresh Kumar
2014-05-28 17:38 ` Mark Brown
2014-06-02 7:20 ` Viresh Kumar
2014-06-02 9:51 ` Mark Brown
2014-06-02 9:54 ` Viresh Kumar
2014-06-02 10:02 ` Mark Brown
2014-06-02 10:15 ` Viresh Kumar
2014-06-02 12:23 ` Mark Brown
2014-06-02 13:14 ` Viresh Kumar
2014-06-02 15:20 ` Mark Brown
2014-06-02 16:55 ` Viresh Kumar
2014-06-03 10:52 ` Mark Brown
2014-06-03 14:40 ` Viresh Kumar
2014-06-03 14:53 ` Mark Brown
2014-06-03 15:22 ` Viresh Kumar
2014-06-03 15:32 ` Mark Brown
2014-06-03 15:35 ` Viresh Kumar
2014-06-03 16:02 ` Mark Brown
2014-06-03 15:25 ` Viresh Kumar
2014-06-03 15:48 ` Mark Brown [this message]
2014-06-04 5:46 ` Viresh Kumar
2014-06-04 10:38 ` Mark Brown
2014-06-04 10:57 ` Viresh Kumar
2014-06-04 12:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603154854.GG31751@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arvind.chauhan@arm.com \
--cc=edubezval@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox