* RE: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28
@ 2014-08-07 9:47 Wei-Chun Pan
2014-08-07 10:01 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Wei-Chun Pan @ 2014-08-07 9:47 UTC (permalink / raw)
To: Lee Jones
Cc: Samuel Ortiz, Jean Delvare, Guenter Roeck, Wolfram Sang, Louis.Lu,
Neo.Lo, Hank.Peng, Kevin.Ong, linux-kernel, Wei-Chun Pan
I have a question for your comment. As your mail,
> > +
> > +static void __exit imanager2_mfd_device_exit(void) {
> > + mfd_remove_devices(&ec_pdev->dev);
> > + platform_device_unregister(ec_pdev);
> > +}
> > +
> > +module_init(imanager2_mfd_device_init);
> > +module_exit(imanager2_mfd_device_exit);
>
> This is a mess. Use module_platform_driver() instead.
>
> > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > +advantech.com>");
> > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > +DRV_VERSION); MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION);
>
How can I use module_platform_driver() and my driver exit function also can do
mfd_remove_devices().
Or any other better function install of mfd_remove_devices()?
Signed-off-by: Wei-Chun Pan <weichun.pan@advantech.com.tw>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28
2014-08-07 9:47 [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28 Wei-Chun Pan
@ 2014-08-07 10:01 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-08-07 10:01 UTC (permalink / raw)
To: Wei-Chun Pan
Cc: Samuel Ortiz, Jean Delvare, Guenter Roeck, Wolfram Sang, Louis.Lu,
Neo.Lo, Hank.Peng, Kevin.Ong, linux-kernel
You've replied to this email as an independent message, so now there
is little context. When you reply, please ensure your mailer replies
to the thread.
On Thu, 07 Aug 2014, Wei-Chun Pan wrote:
> I have a question for your comment. As your mail,
>
> > > +
> > > +static void __exit imanager2_mfd_device_exit(void) {
> > > + mfd_remove_devices(&ec_pdev->dev);
> > > + platform_device_unregister(ec_pdev);
> > > +}
> > > +
> > > +module_init(imanager2_mfd_device_init);
> > > +module_exit(imanager2_mfd_device_exit);
> >
> > This is a mess. Use module_platform_driver() instead.
> >
> > > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > > +advantech.com>");
> > > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > > +DRV_VERSION); MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION);
> >
>
> How can I use module_platform_driver() and my driver exit function also can do
> mfd_remove_devices().
> Or any other better function install of mfd_remove_devices()?
That's the point - you don't do mfd_remove_devices() in exit(), you do
mfd_add_devices() in .probe() and mfd_remove_devices() in .remove().
The only thing you want to do in init() is platform_driver_register(),
or even better - don't have init() and exit() calls and use use
module_platform_driver_probe() instead.
> Signed-off-by: Wei-Chun Pan <weichun.pan@advantech.com.tw>
Not sure why you've signed-off on an email?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28
@ 2014-08-19 10:04 Wei-Chun Pan
2014-08-29 11:23 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Wei-Chun Pan @ 2014-08-19 10:04 UTC (permalink / raw)
To: Lee Jones
Cc: Samuel Ortiz, Jean Delvare, Guenter Roeck, Wolfram Sang, Louis.Lu,
Neo.Lo, Hank.Peng, Kevin.Ong, linux-kernel
> You've replied to this email as an independent message, so now there is little
> context. When you reply, please ensure your mailer replies to the thread.
>
Could you tell me more detail about this?
I use Git to reply mails but don't know how to set them to be dependent on.
> On Thu, 07 Aug 2014, Wei-Chun Pan wrote:
> > I have a question for your comment. As your mail,
> >
> > > > +
> > > > +static void __exit imanager2_mfd_device_exit(void) {
> > > > + mfd_remove_devices(&ec_pdev->dev);
> > > > + platform_device_unregister(ec_pdev);
> > > > +}
> > > > +
> > > > +module_init(imanager2_mfd_device_init);
> > > > +module_exit(imanager2_mfd_device_exit);
> > >
> > > This is a mess. Use module_platform_driver() instead.
> > >
> > > > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > > > +advantech.com>");
> > > > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > > > +DRV_VERSION); MODULE_LICENSE("GPL");
> MODULE_VERSION(DRV_VERSION);
> > >
> >
> > How can I use module_platform_driver() and my driver exit function
> > also can do mfd_remove_devices().
> > Or any other better function install of mfd_remove_devices()?
>
> That's the point - you don't do mfd_remove_devices() in exit(), you do
> mfd_add_devices() in .probe() and mfd_remove_devices() in .remove().
>
> The only thing you want to do in init() is platform_driver_register(), or even better
> - don't have init() and exit() calls and use use
> module_platform_driver_probe() instead.
>
It seems that module_platform_driver() only registers/unregisters driver but not device.
Is there a method to register/unregister my device?
--
Wei-Chun Pan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28
2014-08-19 10:04 Wei-Chun Pan
@ 2014-08-29 11:23 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-08-29 11:23 UTC (permalink / raw)
To: Wei-Chun Pan
Cc: Samuel Ortiz, Jean Delvare, Guenter Roeck, Wolfram Sang, Louis.Lu,
Neo.Lo, Hank.Peng, Kevin.Ong, linux-kernel
On Tue, 19 Aug 2014, Wei-Chun Pan wrote:
> > You've replied to this email as an independent message, so now there is little
> > context. When you reply, please ensure your mailer replies to the thread.
> >
>
> Could you tell me more detail about this?
> I use Git to reply mails but don't know how to set them to be dependent on.
How do you use Git to reply to emails?
> > On Thu, 07 Aug 2014, Wei-Chun Pan wrote:
> > > I have a question for your comment. As your mail,
> > >
> > > > > +
> > > > > +static void __exit imanager2_mfd_device_exit(void) {
> > > > > + mfd_remove_devices(&ec_pdev->dev);
> > > > > + platform_device_unregister(ec_pdev);
> > > > > +}
> > > > > +
> > > > > +module_init(imanager2_mfd_device_init);
> > > > > +module_exit(imanager2_mfd_device_exit);
> > > >
> > > > This is a mess. Use module_platform_driver() instead.
> > > >
> > > > > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > > > > +advantech.com>");
> > > > > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > > > > +DRV_VERSION); MODULE_LICENSE("GPL");
> > MODULE_VERSION(DRV_VERSION);
> > > >
> > >
> > > How can I use module_platform_driver() and my driver exit function
> > > also can do mfd_remove_devices().
> > > Or any other better function install of mfd_remove_devices()?
> >
> > That's the point - you don't do mfd_remove_devices() in exit(), you do
> > mfd_add_devices() in .probe() and mfd_remove_devices() in .remove().
> >
> > The only thing you want to do in init() is platform_driver_register(), or even better
> > - don't have init() and exit() calls and use use
> > module_platform_driver_probe() instead.
> >
>
> It seems that module_platform_driver() only registers/unregisters driver but not device.
> Is there a method to register/unregister my device?
You need to do that from Device Tree or from within arch/<arch>/{mach,plat}-*
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] mfd: imanager2: Add defines support for IT8516/18/28
@ 2014-07-14 12:54 Wei-Chun Pan
2014-07-14 12:54 ` [PATCH 3/4] mfd: imanager2: Add Core supports " Wei-Chun Pan
0 siblings, 1 reply; 6+ messages in thread
From: Wei-Chun Pan @ 2014-07-14 12:54 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, Jean Delvare, Guenter Roeck
Cc: Louis.Lu, Neo.Lo, Hank.Peng, Kevin.Ong, linux-kernel,
Wei-Chun Pan
Signed-off-by: Wei-Chun Pan <weichun.pan@advantech.com.tw>
---
include/linux/mfd/imanager2_ec.h | 358 +++++++++++++++++++++++++++++++++++++++
1 file changed, 358 insertions(+)
create mode 100644 include/linux/mfd/imanager2_ec.h
diff --git a/include/linux/mfd/imanager2_ec.h b/include/linux/mfd/imanager2_ec.h
new file mode 100644
index 0000000..bf7d70e
--- /dev/null
+++ b/include/linux/mfd/imanager2_ec.h
@@ -0,0 +1,358 @@
+/*
+ * imanager2_ec.h - MFD driver defines of Advantech EC IT8516/18/28
+ * Copyright (C) 2014 Richard Vidal-Dorsch <richard.dorsch@advantech.com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef __IMANAGER2_EC_H__
+#define __IMANAGER2_EC_H__
+
+#include <linux/mutex.h>
+
+#define EC_FLAG_IO 0
+#define EC_FLAG_IO_MAILBOX (1 << 0)
+#define EC_FLAG_MAILBOX (1 << 1)
+
+#define EC_MAX_DEVICE_ID_NUM 0xFF
+#define EC_MAX_ITEM_NUM 32
+
+struct ec_table {
+ u8 devid2itemnum[EC_MAX_DEVICE_ID_NUM];
+ u8 pinnum[EC_MAX_ITEM_NUM];
+ u8 devid[EC_MAX_ITEM_NUM];
+};
+
+struct ec_version {
+ u16 kernel_ver,
+ chip_code,
+ prj_id,
+ prj_ver;
+};
+
+#define EC_MAX_LEN_PROJECT_NAME 8
+
+struct imanager2 {
+ u16 id;
+ u32 flag;
+ struct mutex lock; /* protects io */
+ char prj_name[EC_MAX_LEN_PROJECT_NAME + 1]; /* strlen + '\0' */
+ struct ec_version version;
+ struct ec_table table;
+};
+
+/*
+ * Definition
+ */
+#define EC_TABLE_ITEM_UNUSED 0xFF
+#define EC_TABLE_DID_NODEV 0x00
+#define EC_TABLE_HWP_NODEV 0xFF
+#define EC_TABLE_NOITEM 0xFF
+
+#define EC_ERROR 0xFF
+
+#define EC_RAM_BANK_SIZE 32 /* 32 bytes size for each bank. */
+#define EC_RAM_BUFFER_SIZE 256 /* 32 bytes * 8 banks = 256 bytes */
+
+#define EC_SIO_CMD 0x29C
+#define EC_SIO_DATA 0x29D
+
+/* Access Mailbox */
+#define EC_IO_PORT_CMD 0x29A
+#define EC_IO_PORT_DATA 0x299
+
+#define EC_IO_CMD_READ_OFFSET 0xA0
+#define EC_IO_CMD_WRITE_OFFSET 0x50
+
+#define EC_ITE_PORT_OFS 0x29E
+#define EC_ITE_PORT_DATA 0x29F
+
+/*
+ * CMD - IO
+ */
+/* ADC */
+#define EC_CMD_ADC_INDEX 0x15
+#define EC_CMD_ADC_READ_LSB 0x16
+#define EC_CMD_ADC_READ_MSB 0x1F
+/* HW Control Table */
+#define EC_CMD_HWCTRLTABLE_INDEX 0x20
+#define EC_CMD_HWCTRLTABLE_GET_PIN_NUM 0x21
+#define EC_CMD_HWCTRLTABLE_GET_DEVICE_ID 0x22
+#define EC_CMD_HWCTRLTABLE_GET_PIN_ACTIVE_POLARITY 0x23
+/* ACPI RAM */
+#define EC_CMD_ACPIRAM_READ 0x80
+#define EC_CMD_ACPIRAM_WRITE 0x81
+/* Extend RAM */
+#define EC_CMD_EXTRAM_READ 0x86
+#define EC_CMD_EXTRAM_WRITE 0x87
+/* HW RAM */
+#define EC_CMD_HWRAM_READ 0x88
+#define EC_CMD_HWRAM_WRITE 0x89
+
+/*
+ * ACPI RAM Address Table
+ */
+/* n = 1 ~ 2 */
+#define EC_ACPIRAM_ADDR_TEMPERATURE_BASE(n) (0x60 + 3 * ((n) - 1))
+#define EC_ACPIRAM_ADDR_LOCAL_TEMPERATURE(n) \
+ EC_ACPIRAM_ADDR_TEMPERATURE_BASE(n)
+#define EC_ACPIRAM_ADDR_REMOTE_TEMPERATURE(n) \
+ (EC_ACPIRAM_ADDR_TEMPERATURE_BASE(n) + 1)
+#define EC_ACPIRAM_ADDR_WARNING_TEMPERATURE(n)\
+ (EC_ACPIRAM_ADDR_TEMPERATURE_BASE(n) + 2)
+
+/* N = 0 ~ 2 */
+#define EC_ACPIRAM_ADDR_FAN_SPEED_BASE(N) (0x70 + 2 * (N))
+
+#define EC_ACPIRAM_ADDR_KERNEL_MAJOR_VERSION 0xF8
+#define EC_ACPIRAM_ADDR_CHIP_VENDOR_CODE 0xFA
+#define EC_ACPIRAM_ADDR_PROJECT_NAME_CODE 0xFC
+#define EC_ACPIRAM_ADDR_FIRMWARE_MAJOR_VERSION 0xFE
+
+/*
+ * HW RAM Address Table
+ */
+/* Thermal Source Control RAM 0xB0-0xC7 (N: 0 ~ 3) */
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N) (0xB0 + 6 * (N))
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_SMB_CHANNEL(N) \
+ EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N)
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_SMB_ADDR(N) \
+ (EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N) + 1)
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_SMB_CMD(N) \
+ (EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N) + 2)
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_SMB_STATUS(N) \
+ (EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N) + 3)
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_SMB_FAN_CODE(N) \
+ (EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N) + 4)
+#define EC_HWRAM_ADDR_THERMAL_SOURCE_SMB_TEMPERATURE(N) \
+ (EC_HWRAM_ADDR_THERMAL_SOURCE_BASE_ADDR(N) + 5)
+/* Fan Control 0xD0-0xEF (N: 0 ~ 3) */
+#define EC_HWRAM_ADDR_FAN_BASE_ADDR(N) (0xD0 + 0x10 * (N))
+#define EC_HWRAM_ADDR_FAN_CODE(N) EC_HWRAM_ADDR_FAN_BASE_ADDR(N)
+#define EC_HWRAM_ADDR_FAN_STATUS(N) (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 1)
+#define EC_HWRAM_ADDR_FAN_CONTROL(N) (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 2)
+#define EC_HWRAM_ADDR_FAN_TEMP_HI(N) (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 3)
+#define EC_HWRAM_ADDR_FAN_TEMP_LO(N) (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 4)
+#define EC_HWRAM_ADDR_FAN_TEMP_LOSTOP(N) \
+ (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 5)
+#define EC_HWRAM_ADDR_FAN_PWM_HI(N) (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 6)
+#define EC_HWRAM_ADDR_FAN_PWM_LO(N) (EC_HWRAM_ADDR_FAN_BASE_ADDR(N) + 7)
+
+/*
+ * OFS - Mailbox
+ */
+/* Mailbox Structure */
+#define EC_MAILBOX_OFFSET_CMD 0x00
+#define EC_MAILBOX_OFFSET_STATUS 0x01
+#define EC_MAILBOX_OFFSET_PARA 0x02
+#define EC_MAILBOX_OFFSET_DAT(N) (0x03 + (N)) /* N = 0x00 ~ 0x2C */
+
+/*
+ * CMD - Mailbox
+ */
+/* GPIO */
+#define EC_CMD_MAILBOX_READ_HW_PIN 0x11
+#define EC_CMD_MAILBOX_WRITE_HW_PIN 0x12
+/* Storage */
+#define EC_CMD_MAILBOX_READ_EC_RAM 0x1E
+#define EC_CMD_MAILBOX_WRITE_EC_RAM 0x1F
+/* OTHERS */
+#define EC_CMD_MAILBOX_READ_DYNAMIC_TABLE 0x20
+/* Thermal Protect */
+#define EC_CMD_MAILBOX_READ_THERMAL_SOURCE 0x42
+#define EC_CMD_MAILBOX_WRITE_THERMAL_SOURCE 0x43
+/* Storage */
+#define EC_CMD_MALLBOX_CLEAR_256_BYTES_BUFFER 0xC0
+#define EC_CMD_MALLBOX_READ_256_BYTES_BUFFER 0xC1
+#define EC_CMD_MALLBOX_WRITE_256_BYTES_BUFFER 0xC2
+#define EC_CMD_MALLBOX_READ_EEPROM_DATA_FROM_256_BYTES_BUFFER 0xC3
+#define EC_CMD_MALLBOX_WRITE_256_BYTES_BUFFER_INTO_EEPROM_DATA 0xC4
+/* General Mailbox Command */
+#define EC_CMD_MAILBOX_GET_FIRMWARE_VERSION_AND_PROJECT_NAME 0xF0
+#define EC_CMD_MAILBOX_CLEAR_ALL 0xFF
+
+/*
+ * Status - Mailbox
+ */
+#define EC_MAILBOX_STATUS_FAIL 0x00
+#define EC_MAILBOX_STATUS_SUCCESS 0x01
+
+/*
+ * PARA - Mailbox
+ */
+/* RAM Type */
+#define EC_RAM_BANK_ACPI 0x01
+#define EC_RAM_BANK_HW 0x02
+#define EC_RAM_BANK_EXT 0x03
+#define EC_RAM_BANK_BUFFER 0x06
+/* Dynamic Type */
+#define EC_DYNAMIC_DEVICE_ID 0x00
+#define EC_DYNAMIC_HW_PIN 0x01
+#define EC_DYNAMIC_POLARITY 0x02
+
+/*
+ * Functions - Mailbox
+ */
+/* command = 0x20 */
+int imanager2_mbox_get_dynamic_table(u32 ecflag, u8 type, u8 *table);
+/* command = 0x42 */
+int imanager2_mbox_read_thermalzone(u32 ecflag, u8 zone, u8 *smbid, u8 *fanid,
+ u8 *buf, int *len);
+/* command = 0xC0 */
+int imanager2_mbox_clear_ram(u32 ecflag);
+/* command = 0xC1 */
+int imanager2_mbox_read_ram_across_banks(u32 ecflag, u8 *data, int len);
+/* command = 0x1E */
+int imanager2_mbox_read_ram(u32 ecflag, u8 bank, u8 offset, u8 *buf, u8 len);
+/* command = 0x1F */
+int imanager2_mbox_write_ram(u32 ecflag, u8 bank, u8 offset, u8 *buf, u8 len);
+/* command = 0xF0 */
+int imanager2_mbox_get_project_information(u32 ecflag, u8 *prj_name,
+ u16 *kernel_ver, u16 *chip_code,
+ u16 *prj_id, u16 *prj_ver);
+
+/*
+ * Functions - basic
+ */
+#define IO_FLAG_OBF (1 << 0) /* output buffer full */
+#define IO_FLAG_IBF (1 << 1) /* input buffer full */
+int ec_inb_after_obf1(u8 *data);
+int ec_outb_after_ibc0(u16 port, u8 data);
+/* ITE mailbox access */
+int imanager2_mbox_read_data(u32 ecflag, u8 cmd, u8 para, u8 *data, int len);
+int imanager2_mbox_write_data(u32 ecflag, u8 cmd, u8 para, u8 *data, int len);
+/* only IO access */
+int imanager2_mbox_io_read(u8 command, u8 offset, u8 *buf, u8 len);
+int imanager2_mbox_io_write(u8 command, u8 offset, u8 *buf, u8 len);
+int imanager2_mbox_io_simple_read(u8 command, u8 *value);
+/* ITE Mailbox & IO access */
+int imanager2_mbox_read_ram_support_io(u32 ecflag, u8 bank, u8 addr, u8 *buf,
+ u8 len);
+
+/*
+ * Device ID
+ */
+enum ec_device_id {
+ /* GPIO */
+ altgpio0 = 0x10, /* 0x10 */
+ altgpio1,
+ altgpio2,
+ altgpio3,
+ altgpio4,
+ altgpio5,
+ altgpio6,
+ altgpio7,
+ /* GPIO - Button */
+ btn0,
+ btn1,
+ btn2,
+ btn3,
+ btn4,
+ btn5,
+ btn6,
+ btn7,
+ /* PWM - Fan */
+ cpufan_2p, /* 0x20 */
+ cpufan_4p,
+ sysfan1_2p,
+ sysfan1_4p,
+ sysfan2_2p,
+ sysfan2_4p,
+ /* PWM - Brightness Control */
+ pwmbrightness,
+ /* PWM - System Speaker */
+ pwmbeep,
+ /* SMBus */
+ smboem0,
+ smboem1,
+ smboem2,
+ smbeeprom,
+ smbthermal0,
+ smbthermal1,
+ smbsecurityeep,
+ i2coem,
+ /* DAC - Speaker */
+ dacspeaker, /* 0x30 */
+ /* SMBus */
+ smbeep2k = 0x38,
+ oemeep,
+ oemeep2k,
+ peci,
+ smboem3,
+ smblink,
+ smbslv,
+ /* GPIO - LED */
+ powerled = 0x40, /* 0x40 */
+ batledg,
+ oemled0,
+ oemled1,
+ oemled2,
+ batledr,
+ /* SMBus - Smart Battery */
+ smartbat1 = 0x48,
+ smartbat2,
+ /* ADC */
+ adcmosbat = 0x50, /* 0x50 */
+ adcmosbatx2,
+ adcmosbatx10,
+ adcbat,
+ adcbatx2,
+ adcbatx10,
+ adc5vs0,
+ adc5vs0x2,
+ adc5vs0x10,
+ adv5vs5,
+ adv5vs5x2,
+ adv5vs5x10,
+ adc33vs0,
+ adc33vs0x2,
+ adc33vs0x10,
+ adc33vs5,
+ adc33vs5x2, /* 0x60 */
+ adc33vs5x10,
+ adv12vs0,
+ adv12vs0x2,
+ adv12vs0x10,
+ adcvcorea,
+ adcvcoreax2,
+ adcvcoreax10,
+ adcvcoreb,
+ adcvcorebx2,
+ adcvcorebx10,
+ adcdc,
+ adcdcx2,
+ adcdcx10,
+ adcdcstby,
+ adcdcstbyx2,
+ adcdcstbyx10, /* 0x70 */
+ adcdcother,
+ adcdcotherx2,
+ adcdcotherx10,
+ adccurrent,
+ /* IRQ - Watchdog */
+ wdirq = 0x78,
+ /* GPIO - Watchdog */
+ wdnmi,
+ /* Tacho - Fan */
+ tacho0 = 0x80, /* 0x80 */
+ tacho1,
+ tacho2,
+ /* PWM - Brightness Control */
+ pwmbrightness2 = 0x88,
+ /* GPIO - Backlight Control */
+ brionoff1,
+ brionoff2,
+};
+
+#endif /* __IMANAGER2_EC_H__ */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28
2014-07-14 12:54 [PATCH 1/4] mfd: imanager2: Add defines support " Wei-Chun Pan
@ 2014-07-14 12:54 ` Wei-Chun Pan
2014-07-22 8:56 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Wei-Chun Pan @ 2014-07-14 12:54 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, Jean Delvare, Guenter Roeck
Cc: Louis.Lu, Neo.Lo, Hank.Peng, Kevin.Ong, linux-kernel,
Wei-Chun Pan
Signed-off-by: Wei-Chun Pan <weichun.pan@advantech.com.tw>
---
drivers/mfd/Kconfig | 6 +
drivers/mfd/Makefile | 2 +
drivers/mfd/imanager2_core.c | 303 +++++++++++++++++++++++++++++++++++++++++++
3 files changed, 311 insertions(+)
create mode 100644 drivers/mfd/imanager2_core.c
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3383412..48b063f 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -10,6 +10,12 @@ config MFD_CORE
select IRQ_DOMAIN
default n
+config MFD_IMANAGER2
+ tristate "Support for Advantech iManager2 EC ICs"
+ select MFD_CORE
+ help
+ Support for Advantech iManager2 EC ICs
+
config MFD_CS5535
tristate "AMD CS5535 and CS5536 southbridge core functions"
select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 2851275..10c64ae 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -166,3 +166,5 @@ obj-$(CONFIG_MFD_RETU) += retu-mfd.o
obj-$(CONFIG_MFD_AS3711) += as3711.o
obj-$(CONFIG_MFD_AS3722) += as3722.o
obj-$(CONFIG_MFD_STW481X) += stw481x.o
+imanager2-objs := imanager2_core.o imanager2_ec.o
+obj-$(CONFIG_MFD_IMANAGER2) += imanager2.o
diff --git a/drivers/mfd/imanager2_core.c b/drivers/mfd/imanager2_core.c
new file mode 100644
index 0000000..2264d29
--- /dev/null
+++ b/drivers/mfd/imanager2_core.c
@@ -0,0 +1,303 @@
+/*
+ * imanager2_core.c - MFD core driver of Advantech EC IT8516/18/28
+ * Copyright (C) 2014 Richard Vidal-Dorsch <richard.dorsch@advantech.com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/module.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/imanager2_ec.h>
+
+#define DRV_NAME "imanager2"
+#define DRV_VERSION "4.0.1"
+
+static struct mfd_cell imanager2_cells[] = {
+ {
+ .name = "imanager2_hwm",
+ },
+ {
+ .name = "imanager2_i2c",
+ },
+};
+
+enum chips {
+ it8516 = 0x8516,
+ it8518 = 0x8518,
+ it8528 = 0x8528,
+};
+
+#define EC_CMD_AUTHENTICATION 0x30
+
+static int imanager2_authentication(struct imanager2 *ec)
+{
+ u8 tmp;
+ int ret;
+
+ mutex_lock(&ec->lock);
+
+ if (inb(EC_IO_PORT_CMD) == 0xFF && inb(EC_IO_PORT_DATA) == 0xFF) {
+ ret = -ENODEV;
+ goto unlock;
+ }
+
+ if (inb(EC_IO_PORT_CMD) & IO_FLAG_OBF)
+ inb(EC_IO_PORT_DATA); /* initial OBF */
+
+ if (ec_outb_after_ibc0(EC_IO_PORT_CMD, EC_CMD_AUTHENTICATION)) {
+ ret = -ENODEV;
+ goto unlock;
+ }
+
+ ret = ec_inb_after_obf1(&tmp);
+
+unlock:
+ mutex_unlock(&ec->lock);
+
+ if (ret)
+ return ret;
+
+ if (tmp != 0x95)
+ return -ENODEV;
+
+ return 0;
+}
+
+#define EC_ITE_CHIPID_H8 0x20
+#define EC_ITE_CHIPID_L8 0x21
+
+static int imanager2_get_chip_type(struct imanager2 *ec)
+{
+ mutex_lock(&ec->lock);
+
+ outb(EC_ITE_CHIPID_H8, EC_SIO_CMD);
+ ec->id = inb(EC_SIO_DATA) << 8;
+ outb(EC_ITE_CHIPID_L8, EC_SIO_CMD);
+ ec->id |= inb(EC_SIO_DATA);
+
+ mutex_unlock(&ec->lock);
+
+ switch (ec->id) {
+ case it8516:
+ case it8518:
+ ec->flag = EC_FLAG_IO;
+ break;
+ case it8528:
+ ec->flag |= EC_FLAG_IO_MAILBOX;
+ break;
+ default:
+ return -ENODEV;
+ }
+
+ return 0;
+}
+
+/*
+ * EC provides IO channel and ITE mailbox ways to access mailbox. IO channel is
+ * a common way to access mailbox, but IET mailbox way is much faster than IO
+ * channel. We prefer ITE mailbox if firmware supports. Source kernel code
+ * X11_05 the first firmware version that supports ITE mailbox.
+ */
+#define EC_CHIPFW_SUPP_ITEMAILBOX 0x1105
+
+static int imanager2_get_info(struct imanager2 *ec)
+{
+ int ret;
+ u8 *tmp = (u8 *)&ec->version.kernel_ver;
+
+ mutex_lock(&ec->lock);
+
+ ret = imanager2_mbox_io_read(EC_CMD_ACPIRAM_READ,
+ EC_ACPIRAM_ADDR_KERNEL_MAJOR_VERSION,
+ &tmp[0], 2);
+
+ if (ret)
+ goto unlock;
+
+ if (ec->version.kernel_ver >= EC_CHIPFW_SUPP_ITEMAILBOX) {
+ ec->flag |= EC_FLAG_MAILBOX;
+ ret = imanager2_mbox_get_project_information(
+ ec->flag, ec->prj_name,
+ &ec->version.kernel_ver, &ec->version.chip_code,
+ &ec->version.prj_id, &ec->version.prj_ver);
+ } else {
+ ec->flag &= ~EC_FLAG_MAILBOX;
+ ret = imanager2_mbox_io_read(
+ EC_CMD_ACPIRAM_READ,
+ EC_ACPIRAM_ADDR_KERNEL_MAJOR_VERSION,
+ &tmp[0], sizeof(struct ec_version));
+ }
+unlock:
+ mutex_unlock(&ec->lock);
+
+ return ret;
+}
+
+static int imanager2_device_initial_by_ite(struct imanager2 *ec)
+{
+ int i, ret;
+
+ mutex_lock(&ec->lock);
+
+ ret = imanager2_mbox_get_dynamic_table(ec->flag, EC_DYNAMIC_DEVICE_ID,
+ ec->table.devid);
+ if (ret)
+ goto unlock;
+
+ ret = imanager2_mbox_get_dynamic_table(ec->flag, EC_DYNAMIC_HW_PIN,
+ ec->table.pinnum);
+unlock:
+ mutex_unlock(&ec->lock);
+
+ if (ret)
+ return ret;
+
+ for (i = 0; i < EC_MAX_ITEM_NUM; i++) {
+ if (ec->table.devid[i] == EC_TABLE_DID_NODEV)
+ break;
+
+ ec->table.devid2itemnum[ec->table.devid[i]] = i;
+ }
+
+ return 0;
+}
+
+static int imanager2_device_initial_by_io(struct imanager2 *ec)
+{
+ int i, ret;
+ u8 tmp;
+
+ mutex_lock(&ec->lock);
+
+ for (i = 0; i < EC_MAX_ITEM_NUM; i++) {
+ ret = imanager2_mbox_io_read
+ (EC_CMD_HWCTRLTABLE_INDEX, i, &tmp, 1);
+ if (ret)
+ break;
+ if (tmp == EC_TABLE_NOITEM)
+ break;
+
+ ret = imanager2_mbox_io_simple_read(
+ EC_CMD_HWCTRLTABLE_GET_PIN_NUM, &ec->table.pinnum[i]);
+ if (ret)
+ break;
+
+ ret = imanager2_mbox_io_simple_read(
+ EC_CMD_HWCTRLTABLE_GET_DEVICE_ID, &ec->table.devid[i]);
+ if (ret)
+ break;
+
+ if (ec->table.devid[i] == EC_TABLE_DID_NODEV)
+ continue;
+
+ ec->table.devid2itemnum[ec->table.devid[i]] = i;
+ }
+
+ mutex_unlock(&ec->lock);
+
+ if (ret)
+ return ret;
+
+ if (i < EC_MAX_ITEM_NUM) {
+ memset(&ec->table.devid[i], EC_TABLE_DID_NODEV,
+ EC_MAX_ITEM_NUM - i);
+ memset(&ec->table.pinnum[i], EC_TABLE_HWP_NODEV,
+ EC_MAX_ITEM_NUM - i);
+ }
+
+ return ret;
+}
+
+static int imanager2_build_device_table(struct imanager2 *ec)
+{
+ memset(&ec->table.devid2itemnum[0], EC_TABLE_ITEM_UNUSED,
+ ARRAY_SIZE(ec->table.devid2itemnum));
+
+ if (ec->flag & EC_FLAG_MAILBOX)
+ return imanager2_device_initial_by_ite(ec);
+ else
+ return imanager2_device_initial_by_io(ec);
+}
+
+static struct platform_device *ec_pdev;
+
+static int __init imanager2_mfd_device_init(void)
+{
+ struct imanager2 ec = { 0 };
+ int ret;
+
+ mutex_init(&ec.lock);
+
+ ret = imanager2_authentication(&ec);
+ if (ret)
+ return ret;
+
+ ret = imanager2_get_chip_type(&ec);
+ if (ret)
+ return ret;
+
+ ret = imanager2_get_info(&ec);
+ if (ret)
+ return ret;
+
+ ret = imanager2_build_device_table(&ec);
+ if (ret)
+ return ret;
+
+ ec_pdev = platform_device_alloc(DRV_NAME, PLATFORM_DEVID_AUTO);
+ if (!ec_pdev)
+ return -ENOMEM;
+
+ if (!devm_request_region(&ec_pdev->dev, EC_IO_PORT_DATA, 2, DRV_NAME))
+ return -EIO;
+
+ if (!devm_request_region(&ec_pdev->dev, EC_ITE_PORT_OFS, 2, DRV_NAME))
+ return -EIO;
+
+ ret = platform_device_add_data(ec_pdev, &ec, sizeof(struct imanager2));
+ if (ret)
+ goto exit_device_put;
+
+ ret = platform_device_add(ec_pdev);
+ if (ret)
+ goto exit_device_put;
+
+ ret = mfd_add_devices(&ec_pdev->dev, -1, imanager2_cells,
+ ARRAY_SIZE(imanager2_cells), NULL, -1, NULL);
+ if (ret)
+ goto exit_device_unregister;
+
+ return 0;
+
+exit_device_unregister:
+ platform_device_unregister(ec_pdev);
+exit_device_put:
+ platform_device_put(ec_pdev);
+
+ return ret;
+}
+
+static void __exit imanager2_mfd_device_exit(void)
+{
+ mfd_remove_devices(&ec_pdev->dev);
+ platform_device_unregister(ec_pdev);
+}
+
+module_init(imanager2_mfd_device_init);
+module_exit(imanager2_mfd_device_exit);
+
+MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at advantech.com>");
+MODULE_DESCRIPTION("iManager2 platform device definitions v" DRV_VERSION);
+MODULE_LICENSE("GPL");
+MODULE_VERSION(DRV_VERSION);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28
2014-07-14 12:54 ` [PATCH 3/4] mfd: imanager2: Add Core supports " Wei-Chun Pan
@ 2014-07-22 8:56 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2014-07-22 8:56 UTC (permalink / raw)
To: Wei-Chun Pan
Cc: Samuel Ortiz, Jean Delvare, Guenter Roeck, Louis.Lu, Neo.Lo,
Hank.Peng, Kevin.Ong, linux-kernel
There is no way that you are introducing a 300 line driver and have
nothing to say about it. Please put a nice descriptive commit log
here when you resubmit.
> Signed-off-by: Wei-Chun Pan <weichun.pan@advantech.com.tw>
> ---
I also expect to see a change log here and version information in the
$SUBJECT line of the email. I think the next one is v3 (or is it
v4?), so the start of the subject should read [PATCH v4 x/y].
> drivers/mfd/Kconfig | 6 +
> drivers/mfd/Makefile | 2 +
> drivers/mfd/imanager2_core.c | 303 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 311 insertions(+)
> create mode 100644 drivers/mfd/imanager2_core.c
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3383412..48b063f 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -10,6 +10,12 @@ config MFD_CORE
> select IRQ_DOMAIN
> default n
>
> +config MFD_IMANAGER2
> + tristate "Support for Advantech iManager2 EC ICs"
> + select MFD_CORE
> + help
> + Support for Advantech iManager2 EC ICs
> +
> config MFD_CS5535
> tristate "AMD CS5535 and CS5536 southbridge core functions"
> select MFD_CORE
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 2851275..10c64ae 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -166,3 +166,5 @@ obj-$(CONFIG_MFD_RETU) += retu-mfd.o
> obj-$(CONFIG_MFD_AS3711) += as3711.o
> obj-$(CONFIG_MFD_AS3722) += as3722.o
> obj-$(CONFIG_MFD_STW481X) += stw481x.o
> +imanager2-objs := imanager2_core.o imanager2_ec.o
> +obj-$(CONFIG_MFD_IMANAGER2) += imanager2.o
No need to do this. Just do:
obj-$(CONFIG_MFD_IMANAGER2) += imanager2_core.o imanager2_ec.o
> diff --git a/drivers/mfd/imanager2_core.c b/drivers/mfd/imanager2_core.c
> new file mode 100644
> index 0000000..2264d29
> --- /dev/null
> +++ b/drivers/mfd/imanager2_core.c
> @@ -0,0 +1,303 @@
> +/*
> + * imanager2_core.c - MFD core driver of Advantech EC IT8516/18/28
> + * Copyright (C) 2014 Richard Vidal-Dorsch <richard.dorsch@advantech.com>
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 3 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/imanager2_ec.h>
You need more headers than this.
> +#define DRV_NAME "imanager2"
No need to #define the driver name.
Just use the string, where you need to use it.
> +#define DRV_VERSION "4.0.1"
Remove this.
> +static struct mfd_cell imanager2_cells[] = {
> + {
> + .name = "imanager2_hwm",
> + },
> + {
> + .name = "imanager2_i2c",
> + },
Put these on a single line.
> +};
> +
> +enum chips {
> + it8516 = 0x8516,
> + it8518 = 0x8518,
> + it8528 = 0x8528,
s/it/CHIP_IT
> +};
Move this to the top.
> +#define EC_CMD_AUTHENTICATION 0x30
Why is this seperate from the rest of the #defines?
> +static int imanager2_authentication(struct imanager2 *ec)
> +{
> + u8 tmp;
> + int ret;
> +
> + mutex_lock(&ec->lock);
> +
> + if (inb(EC_IO_PORT_CMD) == 0xFF && inb(EC_IO_PORT_DATA) == 0xFF) {
> + ret = -ENODEV;
> + goto unlock;
> + }
> +
> + if (inb(EC_IO_PORT_CMD) & IO_FLAG_OBF)
> + inb(EC_IO_PORT_DATA); /* initial OBF */
What's OBF?
> + if (ec_outb_after_ibc0(EC_IO_PORT_CMD, EC_CMD_AUTHENTICATION)) {
> + ret = -ENODEV;
> + goto unlock;
> + }
> +
> + ret = ec_inb_after_obf1(&tmp);
> +
> +unlock:
> + mutex_unlock(&ec->lock);
> +
> + if (ret)
> + return ret;
Remove this.
> + if (tmp != 0x95)
... and change this to:
if (!ret && tmp != 0x95)
But 0x95 should be #defined somewhere.
> + return -ENODEV;
> +
> + return 0;
> +}
> +
> +#define EC_ITE_CHIPID_H8 0x20
> +#define EC_ITE_CHIPID_L8 0x21
Group all of the #defines somewhere.
> +static int imanager2_get_chip_type(struct imanager2 *ec)
> +{
> + mutex_lock(&ec->lock);
> +
> + outb(EC_ITE_CHIPID_H8, EC_SIO_CMD);
> + ec->id = inb(EC_SIO_DATA) << 8;
> + outb(EC_ITE_CHIPID_L8, EC_SIO_CMD);
> + ec->id |= inb(EC_SIO_DATA);
> +
> + mutex_unlock(&ec->lock);
> +
> + switch (ec->id) {
> + case it8516:
> + case it8518:
> + ec->flag = EC_FLAG_IO;
> + break;
> + case it8528:
> + ec->flag |= EC_FLAG_IO_MAILBOX;
> + break;
> + default:
No error message to the user?
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
[...]
> +static int __init imanager2_mfd_device_init(void)
Drop the '_mfd_device' part of this.
> +{
All of the code below should be in .probe(), not init().
> + struct imanager2 ec = { 0 };
Allocate memory instead.
> + int ret;
> +
> + mutex_init(&ec.lock);
> +
> + ret = imanager2_authentication(&ec);
> + if (ret)
How does the user know what broke? I don't see any err/warn prints?
> + return ret;
> +
> + ret = imanager2_get_chip_type(&ec);
> + if (ret)
> + return ret;
> +
> + ret = imanager2_get_info(&ec);
> + if (ret)
> + return ret;
> +
> + ret = imanager2_build_device_table(&ec);
> + if (ret)
> + return ret;
> +
> + ec_pdev = platform_device_alloc(DRV_NAME, PLATFORM_DEVID_AUTO);
> + if (!ec_pdev)
> + return -ENOMEM;
> +
> + if (!devm_request_region(&ec_pdev->dev, EC_IO_PORT_DATA, 2, DRV_NAME))
> + return -EIO;
> +
> + if (!devm_request_region(&ec_pdev->dev, EC_ITE_PORT_OFS, 2, DRV_NAME))
> + return -EIO;
> +
> + ret = platform_device_add_data(ec_pdev, &ec, sizeof(struct imanager2));
> + if (ret)
> + goto exit_device_put;
> +
> + ret = platform_device_add(ec_pdev);
> + if (ret)
> + goto exit_device_put;
If you convert this driver to be a prober platform device, you can get
rid of all of this above.
> + ret = mfd_add_devices(&ec_pdev->dev, -1, imanager2_cells,
> + ARRAY_SIZE(imanager2_cells), NULL, -1, NULL);
> + if (ret)
> + goto exit_device_unregister;
> +
> + return 0;
> +
> +exit_device_unregister:
> + platform_device_unregister(ec_pdev);
> +exit_device_put:
> + platform_device_put(ec_pdev);
> +
> + return ret;
> +}
> +
> +static void __exit imanager2_mfd_device_exit(void)
> +{
> + mfd_remove_devices(&ec_pdev->dev);
> + platform_device_unregister(ec_pdev);
> +}
> +
> +module_init(imanager2_mfd_device_init);
> +module_exit(imanager2_mfd_device_exit);
This is a mess. Use module_platform_driver() instead.
> +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at advantech.com>");
> +MODULE_DESCRIPTION("iManager2 platform device definitions v" DRV_VERSION);
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION(DRV_VERSION);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-29 11:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-07 9:47 [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28 Wei-Chun Pan
2014-08-07 10:01 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2014-08-19 10:04 Wei-Chun Pan
2014-08-29 11:23 ` Lee Jones
2014-07-14 12:54 [PATCH 1/4] mfd: imanager2: Add defines support " Wei-Chun Pan
2014-07-14 12:54 ` [PATCH 3/4] mfd: imanager2: Add Core supports " Wei-Chun Pan
2014-07-22 8:56 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox