* [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice @ 2014-08-29 13:08 Stefan Hengelein 2014-08-29 18:31 ` Josh Triplett 2014-09-02 17:07 ` Paul E. McKenney 0 siblings, 2 replies; 5+ messages in thread From: Stefan Hengelein @ 2014-08-29 13:08 UTC (permalink / raw) To: linux-kernel Cc: akpm, jkosina, paul.gortmaker, mhocko, mattst88, josh, geert, khilman, Stefan Hengelein, Andreas Ruprecht Every choice item of the "Build-forced no-CBs CPUs" choice had a dependency to RCU_NOCB_CPU. It's more comprehensible if the choice itself has the dependency instead of every choice item. The choice itself doesn't need to be visible if there are no items selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> Signed-off-by: Andreas Ruprecht <rupran@einserver.de> --- init/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index 197b563..d604000 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -729,6 +729,7 @@ config RCU_NOCB_CPU choice prompt "Build-forced no-CBs CPUs" default RCU_NOCB_CPU_NONE + depends on RCU_NOCB_CPU help This option allows no-CBs CPUs (whose RCU callbacks are invoked from kthreads rather than from softirq context) to be specified @@ -737,7 +738,7 @@ choice config RCU_NOCB_CPU_NONE bool "No build_forced no-CBs CPUs" - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL + depends on !NO_HZ_FULL_ALL help This option does not force any of the CPUs to be no-CBs CPUs. Only CPUs designated by the rcu_nocbs= boot parameter will be @@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE config RCU_NOCB_CPU_ZERO bool "CPU 0 is a build_forced no-CBs CPU" - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL + depends on !NO_HZ_FULL_ALL help This option forces CPU 0 to be a no-CBs CPU, so that its RCU callbacks are invoked by a per-CPU kthread whose name begins @@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO config RCU_NOCB_CPU_ALL bool "All CPUs are build_forced no-CBs CPUs" - depends on RCU_NOCB_CPU help This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= boot parameter will be ignored. All CPUs' RCU callbacks will -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice 2014-08-29 13:08 [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice Stefan Hengelein @ 2014-08-29 18:31 ` Josh Triplett 2014-09-02 17:07 ` Paul E. McKenney 1 sibling, 0 replies; 5+ messages in thread From: Josh Triplett @ 2014-08-29 18:31 UTC (permalink / raw) To: Stefan Hengelein Cc: linux-kernel, akpm, jkosina, paul.gortmaker, mhocko, mattst88, geert, khilman, Andreas Ruprecht On Fri, Aug 29, 2014 at 03:08:20PM +0200, Stefan Hengelein wrote: > Every choice item of the "Build-forced no-CBs CPUs" choice had a > dependency to RCU_NOCB_CPU. It's more comprehensible if the choice > itself has the dependency instead of every choice item. > The choice itself doesn't need to be visible if there are no items > selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. > > Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> > Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Makes sense; nice cleanup. Reviewed-by: Josh Triplett <josh@joshtriplett.org> > init/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 197b563..d604000 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -729,6 +729,7 @@ config RCU_NOCB_CPU > choice > prompt "Build-forced no-CBs CPUs" > default RCU_NOCB_CPU_NONE > + depends on RCU_NOCB_CPU > help > This option allows no-CBs CPUs (whose RCU callbacks are invoked > from kthreads rather than from softirq context) to be specified > @@ -737,7 +738,7 @@ choice > > config RCU_NOCB_CPU_NONE > bool "No build_forced no-CBs CPUs" > - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL > + depends on !NO_HZ_FULL_ALL > help > This option does not force any of the CPUs to be no-CBs CPUs. > Only CPUs designated by the rcu_nocbs= boot parameter will be > @@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE > > config RCU_NOCB_CPU_ZERO > bool "CPU 0 is a build_forced no-CBs CPU" > - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL > + depends on !NO_HZ_FULL_ALL > help > This option forces CPU 0 to be a no-CBs CPU, so that its RCU > callbacks are invoked by a per-CPU kthread whose name begins > @@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO > > config RCU_NOCB_CPU_ALL > bool "All CPUs are build_forced no-CBs CPUs" > - depends on RCU_NOCB_CPU > help > This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= > boot parameter will be ignored. All CPUs' RCU callbacks will > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice 2014-08-29 13:08 [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice Stefan Hengelein 2014-08-29 18:31 ` Josh Triplett @ 2014-09-02 17:07 ` Paul E. McKenney 2014-09-02 18:05 ` Stefan Hengelein 1 sibling, 1 reply; 5+ messages in thread From: Paul E. McKenney @ 2014-09-02 17:07 UTC (permalink / raw) To: Stefan Hengelein Cc: linux-kernel, akpm, jkosina, paul.gortmaker, mhocko, mattst88, josh, geert, khilman, Andreas Ruprecht On Fri, Aug 29, 2014 at 03:08:20PM +0200, Stefan Hengelein wrote: > Every choice item of the "Build-forced no-CBs CPUs" choice had a > dependency to RCU_NOCB_CPU. It's more comprehensible if the choice > itself has the dependency instead of every choice item. > The choice itself doesn't need to be visible if there are no items > selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. > > Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> > Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Looks like a nice improvement, but could you please forward-port to branch rcu/dev of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git? Thanx, Paul > --- > init/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 197b563..d604000 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -729,6 +729,7 @@ config RCU_NOCB_CPU > choice > prompt "Build-forced no-CBs CPUs" > default RCU_NOCB_CPU_NONE > + depends on RCU_NOCB_CPU > help > This option allows no-CBs CPUs (whose RCU callbacks are invoked > from kthreads rather than from softirq context) to be specified > @@ -737,7 +738,7 @@ choice > > config RCU_NOCB_CPU_NONE > bool "No build_forced no-CBs CPUs" > - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL > + depends on !NO_HZ_FULL_ALL > help > This option does not force any of the CPUs to be no-CBs CPUs. > Only CPUs designated by the rcu_nocbs= boot parameter will be > @@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE > > config RCU_NOCB_CPU_ZERO > bool "CPU 0 is a build_forced no-CBs CPU" > - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL > + depends on !NO_HZ_FULL_ALL > help > This option forces CPU 0 to be a no-CBs CPU, so that its RCU > callbacks are invoked by a per-CPU kthread whose name begins > @@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO > > config RCU_NOCB_CPU_ALL > bool "All CPUs are build_forced no-CBs CPUs" > - depends on RCU_NOCB_CPU > help > This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= > boot parameter will be ignored. All CPUs' RCU callbacks will > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice 2014-09-02 17:07 ` Paul E. McKenney @ 2014-09-02 18:05 ` Stefan Hengelein 2014-09-02 19:11 ` Paul E. McKenney 0 siblings, 1 reply; 5+ messages in thread From: Stefan Hengelein @ 2014-09-02 18:05 UTC (permalink / raw) To: paulmck Cc: linux-kernel, akpm, jkosina, paul.gortmaker, mhocko, mattst88, josh, geert, khilman, Andreas Ruprecht [-- Attachment #1: Type: text/plain, Size: 2780 bytes --] 2014-09-02 19:07 GMT+02:00 Paul E. McKenney <paulmck@linux.vnet.ibm.com>: > On Fri, Aug 29, 2014 at 03:08:20PM +0200, Stefan Hengelein wrote: >> Every choice item of the "Build-forced no-CBs CPUs" choice had a >> dependency to RCU_NOCB_CPU. It's more comprehensible if the choice >> itself has the dependency instead of every choice item. >> The choice itself doesn't need to be visible if there are no items >> selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. >> >> Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> >> Signed-off-by: Andreas Ruprecht <rupran@einserver.de> > > Looks like a nice improvement, but could you please forward-port to branch > rcu/dev of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git? > > Thanx, Paul done, i attached the adjusted patch. Best Regards, Stefan > >> --- >> init/Kconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/init/Kconfig b/init/Kconfig >> index 197b563..d604000 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -729,6 +729,7 @@ config RCU_NOCB_CPU >> choice >> prompt "Build-forced no-CBs CPUs" >> default RCU_NOCB_CPU_NONE >> + depends on RCU_NOCB_CPU >> help >> This option allows no-CBs CPUs (whose RCU callbacks are invoked >> from kthreads rather than from softirq context) to be specified >> @@ -737,7 +738,7 @@ choice >> >> config RCU_NOCB_CPU_NONE >> bool "No build_forced no-CBs CPUs" >> - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL >> + depends on !NO_HZ_FULL_ALL >> help >> This option does not force any of the CPUs to be no-CBs CPUs. >> Only CPUs designated by the rcu_nocbs= boot parameter will be >> @@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE >> >> config RCU_NOCB_CPU_ZERO >> bool "CPU 0 is a build_forced no-CBs CPU" >> - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL >> + depends on !NO_HZ_FULL_ALL >> help >> This option forces CPU 0 to be a no-CBs CPU, so that its RCU >> callbacks are invoked by a per-CPU kthread whose name begins >> @@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO >> >> config RCU_NOCB_CPU_ALL >> bool "All CPUs are build_forced no-CBs CPUs" >> - depends on RCU_NOCB_CPU >> help >> This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= >> boot parameter will be ignored. All CPUs' RCU callbacks will >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > [-- Attachment #2: 0001-init-Kconfig-move-RCU_NOCB_CPU-dependencies-to-choic.patch --] [-- Type: text/x-patch, Size: 2070 bytes --] From 1f82e1240eba4b31091bcff0e3c126853adacb53 Mon Sep 17 00:00:00 2001 From: Stefan Hengelein <stefan.hengelein@fau.de> Date: Tue, 2 Sep 2014 19:55:11 +0200 Subject: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice Every choice item of the "Build-forced no-CBs CPUs" choice had a dependency to RCU_NOCB_CPU. It's more comprehensible if the choice itself has the dependency instead of every choice item. The choice itself doesn't need to be visible if there are no items selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- init/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index 4fe5500..95a1447 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -739,6 +739,7 @@ config RCU_NOCB_CPU choice prompt "Build-forced no-CBs CPUs" default RCU_NOCB_CPU_NONE + depends on RCU_NOCB_CPU help This option allows no-CBs CPUs (whose RCU callbacks are invoked from kthreads rather than from softirq context) to be specified @@ -747,7 +748,6 @@ choice config RCU_NOCB_CPU_NONE bool "No build_forced no-CBs CPUs" - depends on RCU_NOCB_CPU help This option does not force any of the CPUs to be no-CBs CPUs. Only CPUs designated by the rcu_nocbs= boot parameter will be @@ -761,7 +761,6 @@ config RCU_NOCB_CPU_NONE config RCU_NOCB_CPU_ZERO bool "CPU 0 is a build_forced no-CBs CPU" - depends on RCU_NOCB_CPU help This option forces CPU 0 to be a no-CBs CPU, so that its RCU callbacks are invoked by a per-CPU kthread whose name begins @@ -776,7 +775,6 @@ config RCU_NOCB_CPU_ZERO config RCU_NOCB_CPU_ALL bool "All CPUs are build_forced no-CBs CPUs" - depends on RCU_NOCB_CPU help This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= boot parameter will be ignored. All CPUs' RCU callbacks will -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice 2014-09-02 18:05 ` Stefan Hengelein @ 2014-09-02 19:11 ` Paul E. McKenney 0 siblings, 0 replies; 5+ messages in thread From: Paul E. McKenney @ 2014-09-02 19:11 UTC (permalink / raw) To: Stefan Hengelein Cc: linux-kernel, akpm, jkosina, paul.gortmaker, mhocko, mattst88, josh, geert, khilman, Andreas Ruprecht On Tue, Sep 02, 2014 at 08:05:48PM +0200, Stefan Hengelein wrote: > 2014-09-02 19:07 GMT+02:00 Paul E. McKenney <paulmck@linux.vnet.ibm.com>: > > On Fri, Aug 29, 2014 at 03:08:20PM +0200, Stefan Hengelein wrote: > >> Every choice item of the "Build-forced no-CBs CPUs" choice had a > >> dependency to RCU_NOCB_CPU. It's more comprehensible if the choice > >> itself has the dependency instead of every choice item. > >> The choice itself doesn't need to be visible if there are no items > >> selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. > >> > >> Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> > >> Signed-off-by: Andreas Ruprecht <rupran@einserver.de> > > > > Looks like a nice improvement, but could you please forward-port to branch > > rcu/dev of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git? > > > > Thanx, Paul > > done, i attached the adjusted patch. Queued, thank you! Thanx, Paul > Best Regards, > Stefan > > > > >> --- > >> init/Kconfig | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/init/Kconfig b/init/Kconfig > >> index 197b563..d604000 100644 > >> --- a/init/Kconfig > >> +++ b/init/Kconfig > >> @@ -729,6 +729,7 @@ config RCU_NOCB_CPU > >> choice > >> prompt "Build-forced no-CBs CPUs" > >> default RCU_NOCB_CPU_NONE > >> + depends on RCU_NOCB_CPU > >> help > >> This option allows no-CBs CPUs (whose RCU callbacks are invoked > >> from kthreads rather than from softirq context) to be specified > >> @@ -737,7 +738,7 @@ choice > >> > >> config RCU_NOCB_CPU_NONE > >> bool "No build_forced no-CBs CPUs" > >> - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL > >> + depends on !NO_HZ_FULL_ALL > >> help > >> This option does not force any of the CPUs to be no-CBs CPUs. > >> Only CPUs designated by the rcu_nocbs= boot parameter will be > >> @@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE > >> > >> config RCU_NOCB_CPU_ZERO > >> bool "CPU 0 is a build_forced no-CBs CPU" > >> - depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL > >> + depends on !NO_HZ_FULL_ALL > >> help > >> This option forces CPU 0 to be a no-CBs CPU, so that its RCU > >> callbacks are invoked by a per-CPU kthread whose name begins > >> @@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO > >> > >> config RCU_NOCB_CPU_ALL > >> bool "All CPUs are build_forced no-CBs CPUs" > >> - depends on RCU_NOCB_CPU > >> help > >> This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= > >> boot parameter will be ignored. All CPUs' RCU callbacks will > >> -- > >> 1.9.1 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > >> > > > From 1f82e1240eba4b31091bcff0e3c126853adacb53 Mon Sep 17 00:00:00 2001 > From: Stefan Hengelein <stefan.hengelein@fau.de> > Date: Tue, 2 Sep 2014 19:55:11 +0200 > Subject: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice > > Every choice item of the "Build-forced no-CBs CPUs" choice had a > dependency to RCU_NOCB_CPU. It's more comprehensible if the choice > itself has the dependency instead of every choice item. The choice > itself doesn't need to be visible if there are no items selectable > (i.e. on arch/frv) or RCU_NOCB_CPU is not defined. > > Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de> > Signed-off-by: Andreas Ruprecht <rupran@einserver.de> > Reviewed-by: Josh Triplett <josh@joshtriplett.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > init/Kconfig | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 4fe5500..95a1447 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -739,6 +739,7 @@ config RCU_NOCB_CPU > choice > prompt "Build-forced no-CBs CPUs" > default RCU_NOCB_CPU_NONE > + depends on RCU_NOCB_CPU > help > This option allows no-CBs CPUs (whose RCU callbacks are invoked > from kthreads rather than from softirq context) to be specified > @@ -747,7 +748,6 @@ choice > > config RCU_NOCB_CPU_NONE > bool "No build_forced no-CBs CPUs" > - depends on RCU_NOCB_CPU > help > This option does not force any of the CPUs to be no-CBs CPUs. > Only CPUs designated by the rcu_nocbs= boot parameter will be > @@ -761,7 +761,6 @@ config RCU_NOCB_CPU_NONE > > config RCU_NOCB_CPU_ZERO > bool "CPU 0 is a build_forced no-CBs CPU" > - depends on RCU_NOCB_CPU > help > This option forces CPU 0 to be a no-CBs CPU, so that its RCU > callbacks are invoked by a per-CPU kthread whose name begins > @@ -776,7 +775,6 @@ config RCU_NOCB_CPU_ZERO > > config RCU_NOCB_CPU_ALL > bool "All CPUs are build_forced no-CBs CPUs" > - depends on RCU_NOCB_CPU > help > This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs= > boot parameter will be ignored. All CPUs' RCU callbacks will > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-02 19:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-29 13:08 [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice Stefan Hengelein 2014-08-29 18:31 ` Josh Triplett 2014-09-02 17:07 ` Paul E. McKenney 2014-09-02 18:05 ` Stefan Hengelein 2014-09-02 19:11 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox