* [PATCH] staging: lustre: lnet: lib-ptl.c: sparsa warning: symbol not declared
@ 2014-08-31 9:53 Sudip Mukherjee
2014-09-01 9:34 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2014-08-31 9:53 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sudip Mukherjee, devel, linux-kernel
fixed sparse warning of following symbol not declared:
warning: symbol 'lnet_ptl_cleanup' was not declared. Should it be static?
warning: symbol 'lnet_ptl_setup' was not declared. Should it be static?
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
As of now these functions are not being called from any other file, so i guess its safe to make them static.
drivers/staging/lustre/lnet/lnet/lib-ptl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
index 91767c9..720c73b 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-ptl.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
@@ -712,7 +712,7 @@ lnet_ptl_attach_md(lnet_me_t *me, lnet_libmd_t *md,
lnet_ptl_unlock(ptl);
}
-void
+static void
lnet_ptl_cleanup(struct lnet_portal *ptl)
{
struct lnet_match_table *mtable;
@@ -750,7 +750,7 @@ lnet_ptl_cleanup(struct lnet_portal *ptl)
ptl->ptl_mtables = NULL;
}
-int
+static int
lnet_ptl_setup(struct lnet_portal *ptl, int index)
{
struct lnet_match_table *mtable;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: lnet: lib-ptl.c: sparsa warning: symbol not declared
2014-08-31 9:53 [PATCH] staging: lustre: lnet: lib-ptl.c: sparsa warning: symbol not declared Sudip Mukherjee
@ 2014-09-01 9:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-09-01 9:34 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Greg Kroah-Hartman, devel, linux-kernel
On Sun, Aug 31, 2014 at 03:23:35PM +0530, Sudip Mukherjee wrote:
> fixed sparse warning of following symbol not declared:
> warning: symbol 'lnet_ptl_cleanup' was not declared. Should it be static?
> warning: symbol 'lnet_ptl_setup' was not declared. Should it be static?
>
>
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> As of now these functions are not being called from any other file, so i guess its safe to make them static.
>
Next time put this in the patch description instead of below the
cut-off.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-01 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-31 9:53 [PATCH] staging: lustre: lnet: lib-ptl.c: sparsa warning: symbol not declared Sudip Mukherjee
2014-09-01 9:34 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox