The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs
Date: Fri, 26 Sep 2014 09:44:03 +0100	[thread overview]
Message-ID: <20140926084403.GK5182@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <de6767070ea644d5830778059770451f@BY2PR0301MB0613.namprd03.prod.outlook.com>

On Fri, Sep 26, 2014 at 08:39:04AM +0000, Li.Xiubo@freescale.com wrote:
> [...]
> > On Fri, Sep 26, 2014 at 05:30:40AM +0000, Li.Xiubo@freescale.com wrote:
> > > Hi Russell,
> > >
> > > I'd like to know the status of this patch.
> > >
> > > Our Platforms depend on it.
> > 
> > I'm not applying it.  This option should not be exposed for general
> > use.  The usage pattern is clear from the existing users - propose
> > an alternative default value for your platform rather than making it
> > a user visible tweakable option.
> > 
> 
> Okay.
> 
> Something like :
> ++++++++++
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 1ad6fb6..5729a2c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1802,7 +1802,7 @@ source "mm/Kconfig"
>  config FORCE_MAX_ZONEORDER
>         int "Maximum zone order" if ARCH_SHMOBILE
>         range 11 64 if ARCH_SHMOBILE
> -       default "12" if SOC_AM33XX
> +       default "12" if SOC_AM33XX || SOC_LS1021A
>         default "9" if SA1111
>         default "11"
>         help
> ----------
> 
> Is okay ?

It's much better than exposing the option, but I'd like this patch to
appear as a properly submitted change (including a change log which
provides the reason why this is necessary.)

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2014-09-26  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01  4:42 [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs Xiubo Li
2014-09-26  5:30 ` Li.Xiubo
2014-09-26  8:20   ` Russell King - ARM Linux
2014-09-26  8:39     ` Li.Xiubo
2014-09-26  8:44       ` Russell King - ARM Linux [this message]
2014-09-26  8:46         ` Li.Xiubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926084403.GK5182@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Li.Xiubo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox