Re: [LKP] [net] 4ed2d765dfa: ltp.recv01.4.TFAIL

Re: [LKP] [net] 4ed2d765dfa: ltp.recv01.4.TFAIL

[Daniel Borkmann]

On 10/01/2014 05:29 PM, Fengguang Wu wrote:
> Hi Willem,
>
> FYI, we noticed the below LTP failures on commit
>
> 4ed2d765dfaccff5ebdac68e2064b59125033a3b ("net-timestamp: TCP timestamping")

I think it already was discussed here:

   http://www.spinics.net/lists/netdev/msg297822.html

Re: [LKP] [net] 4ed2d765dfa: ltp.recv01.4.TFAIL

[Chuck Ebbert]

On Wed, 01 Oct 2014 17:57:20 +0200
Daniel Borkmann <dborkman@redhat.com> wrote:

> On 10/01/2014 05:29 PM, Fengguang Wu wrote:
> > Hi Willem,
> >
> > FYI, we noticed the below LTP failures on commit
> >
> > 4ed2d765dfaccff5ebdac68e2064b59125033a3b ("net-timestamp: TCP timestamping")
> 
> I think it already was discussed here:
> 
>    http://www.spinics.net/lists/netdev/msg297822.html


I've fixed one of those in LTP.

My proposed patch for how to fix the other three didn't get any replies
on the LTP list:

http://sourceforge.net/p/ltp/mailman/message/32866727/

Re: [LKP] [net] 4ed2d765dfa: ltp.recv01.4.TFAIL

[Willem de Bruijn]

On Wed, Oct 1, 2014 at 11:29 AM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> Hi Willem,
>
> FYI, we noticed the below LTP failures on commit

Thanks for the report, Fengguang. The failures are

recv01      4  TFAIL  :  recv01.c:142: invalid flags set ; returned -1
(expected -1), errno 11 (expected 22)
recvfrom01    4  TFAIL  :  recvfrom01.c:164: invalid socket length ;
returned -1 (expected -1), errno 11 (expected 22)
recvfrom01    6  TFAIL  :  recvfrom01.c:164: invalid flags set ;
returned -1 (expected -1), errno 11 (expected 22)
recvmsg01    9  TFAIL  :  recvmsg01.c:228: invalid flags set ;
returned -1 (expected -1), errno 11 (expected 22)

In other words, these functions return EAGAIN now, when they used to
return EINVAL. This will happen from this patch onwards if flags
includes MSG_ERRQUEUE. The patch introduced error queue support for
TCP sockets. Like other recvmsg implementations, the error queue code
will act on some flags and ignore others. Previously, the code
happened to check MSG_OOB first and return EINVAL. The error queue
code ignores this flag and returns EAGAIN if no data is waiting.

This was recently discussed in

  LTP recv/recvmsg tests failing on 3.17
  http://comments.gmane.org/gmane.linux.network/331750

where the consensus was that applications should not expect
particular error codes when passing unsupported combinations
of flags.