* acpitool - /proc/acpi/wakeup @ 2014-10-09 19:04 Marc Burkhardt 2014-10-09 19:13 ` Marc Burkhardt 2014-10-09 19:25 ` Frans Klaver 0 siblings, 2 replies; 10+ messages in thread From: Marc Burkhardt @ 2014-10-09 19:04 UTC (permalink / raw) To: linux-kernel Hi there, I noticed, that 'acpitool -e' doesn't work any longer sind I upgraded to 3.17. The tool stalls at Device S-state Status Sysfs node --------------------------------------- 1. LID S3 *enabled platform:PNP0C0D:00 2. SLPB S3 *enabled platform:PNP0C0E:0 Before there were 11 entries shown. Can I help investigate it? Thanks, Marc -- Marc Burkhardt ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:04 acpitool - /proc/acpi/wakeup Marc Burkhardt @ 2014-10-09 19:13 ` Marc Burkhardt 2014-10-09 19:25 ` Frans Klaver 1 sibling, 0 replies; 10+ messages in thread From: Marc Burkhardt @ 2014-10-09 19:13 UTC (permalink / raw) To: Marc Burkhardt; +Cc: linux-kernel * Marc Burkhardt <marc@osknowledge.org> [2014-10-09 21:04:06 +0200]: Just another note: the process uses 100% CPU while 'waiting' for further data it seems... strace shows nothing suspicious. Thanks, Marc > Hi there, > I noticed, that 'acpitool -e' doesn't work any longer sind I upgraded to 3.17. > The tool stalls at > > Device S-state Status Sysfs node > --------------------------------------- > 1. LID S3 *enabled platform:PNP0C0D:00 > 2. SLPB S3 *enabled platform:PNP0C0E:0 > > Before there were 11 entries shown. > > Can I help investigate it? > > Thanks, > Marc > > -- > Marc Burkhardt -- Marc Burkhardt ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:04 acpitool - /proc/acpi/wakeup Marc Burkhardt 2014-10-09 19:13 ` Marc Burkhardt @ 2014-10-09 19:25 ` Frans Klaver 2014-10-09 19:31 ` Frans Klaver 1 sibling, 1 reply; 10+ messages in thread From: Frans Klaver @ 2014-10-09 19:25 UTC (permalink / raw) To: Marc Burkhardt; +Cc: linux-kernel@vger.kernel.org Hi, On Thu, Oct 9, 2014 at 9:04 PM, Marc Burkhardt <marc@osknowledge.org> wrote: > Hi there, > I noticed, that 'acpitool -e' doesn't work any longer sind I upgraded to 3.17. > The tool stalls at > > Device S-state Status Sysfs node > --------------------------------------- > 1. LID S3 *enabled platform:PNP0C0D:00 > 2. SLPB S3 *enabled platform:PNP0C0E:0 I see the same thing. Frans ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:25 ` Frans Klaver @ 2014-10-09 19:31 ` Frans Klaver 2014-10-09 19:42 ` Marc Burkhardt 0 siblings, 1 reply; 10+ messages in thread From: Frans Klaver @ 2014-10-09 19:31 UTC (permalink / raw) To: Marc Burkhardt; +Cc: linux-kernel@vger.kernel.org On Thu, Oct 9, 2014 at 9:25 PM, Frans Klaver <fransklaver@gmail.com> wrote: > Hi, > > On Thu, Oct 9, 2014 at 9:04 PM, Marc Burkhardt <marc@osknowledge.org> wrote: >> Hi there, >> I noticed, that 'acpitool -e' doesn't work any longer sind I upgraded to 3.17. >> The tool stalls at >> >> Device S-state Status Sysfs node >> --------------------------------------- >> 1. LID S3 *enabled platform:PNP0C0D:00 >> 2. SLPB S3 *enabled platform:PNP0C0E:0 > > I see the same thing. With which kernel version did it last work properly for you? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:31 ` Frans Klaver @ 2014-10-09 19:42 ` Marc Burkhardt 2014-10-09 19:48 ` Frans Klaver 0 siblings, 1 reply; 10+ messages in thread From: Marc Burkhardt @ 2014-10-09 19:42 UTC (permalink / raw) To: Frans Klaver; +Cc: linux-kernel@vger.kernel.org I upgraded from 3.10 on that machine. 3.12 didn't work for me due to a hibernation bug. The rest was left out... :/ Thanks, Marc Am 9. Oktober 2014 21:31:52 MESZ, schrieb Frans Klaver <fransklaver@gmail.com>: >On Thu, Oct 9, 2014 at 9:25 PM, Frans Klaver <fransklaver@gmail.com> >wrote: >> Hi, >> >> On Thu, Oct 9, 2014 at 9:04 PM, Marc Burkhardt <marc@osknowledge.org> >wrote: >>> Hi there, >>> I noticed, that 'acpitool -e' doesn't work any longer sind I >upgraded to 3.17. >>> The tool stalls at >>> >>> Device S-state Status Sysfs node >>> --------------------------------------- >>> 1. LID S3 *enabled platform:PNP0C0D:00 >>> 2. SLPB S3 *enabled platform:PNP0C0E:0 >> >> I see the same thing. > >With which kernel version did it last work properly for you? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:42 ` Marc Burkhardt @ 2014-10-09 19:48 ` Frans Klaver 2014-10-09 19:58 ` Marc Burkhardt 0 siblings, 1 reply; 10+ messages in thread From: Frans Klaver @ 2014-10-09 19:48 UTC (permalink / raw) To: Marc Burkhardt; +Cc: linux-kernel@vger.kernel.org Hi, Please put your replies below the relevant quote. On Thu, Oct 9, 2014 at 9:42 PM, Marc Burkhardt <marc@osknowledge.org> wrote: > I upgraded from 3.10 on that machine. 3.12 didn't work for me due to a hibernation bug. The rest was left out... :/ If you still have the 3.12 kernel around, could you test if acpitool -e worked there? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:48 ` Frans Klaver @ 2014-10-09 19:58 ` Marc Burkhardt 2014-10-09 20:16 ` Frans Klaver 0 siblings, 1 reply; 10+ messages in thread From: Marc Burkhardt @ 2014-10-09 19:58 UTC (permalink / raw) To: Frans Klaver; +Cc: linux-kernel@vger.kernel.org >On Thu, Oct 9, 2014 at 9:42 PM, Marc Burkhardt <marc@osknowledge.org> >wrote: >> I upgraded from 3.10 on that machine. 3.12 didn't work for me due to >a hibernation bug. The rest was left out... :/ > >If you still have the 3.12 kernel around, could you test if acpitool >-e worked there? Let me ask you a question: does it make sense to test 3.12 again because you know there's something changed regarding /proc/acpi/... or because it's the kernel I broke up on upgrading? I could compile one, sure. But I have no time to actually 'bisect' this... unfortunately. Thanks for your support, Marc ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 19:58 ` Marc Burkhardt @ 2014-10-09 20:16 ` Frans Klaver 2014-10-09 20:27 ` Chuck Ebbert 0 siblings, 1 reply; 10+ messages in thread From: Frans Klaver @ 2014-10-09 20:16 UTC (permalink / raw) To: Marc Burkhardt; +Cc: linux-kernel@vger.kernel.org On Thu, Oct 9, 2014 at 9:58 PM, Marc Burkhardt <marc@osknowledge.org> wrote: > > >>On Thu, Oct 9, 2014 at 9:42 PM, Marc Burkhardt <marc@osknowledge.org> >>wrote: >>> I upgraded from 3.10 on that machine. 3.12 didn't work for me due to >>a hibernation bug. The rest was left out... :/ >> >>If you still have the 3.12 kernel around, could you test if acpitool >>-e worked there? > > Let me ask you a question: does it make sense to test 3.12 again because you know there's something changed regarding /proc/acpi/... or because it's the kernel I broke up on upgrading? Never mind. It broke after 3.14. I'll bisect. Frans ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 20:16 ` Frans Klaver @ 2014-10-09 20:27 ` Chuck Ebbert 2014-10-09 21:28 ` Frans Klaver 0 siblings, 1 reply; 10+ messages in thread From: Chuck Ebbert @ 2014-10-09 20:27 UTC (permalink / raw) To: Frans Klaver; +Cc: Marc Burkhardt, linux-kernel@vger.kernel.org On Thu, 9 Oct 2014 22:16:11 +0200 Frans Klaver <fransklaver@gmail.com> wrote: > On Thu, Oct 9, 2014 at 9:58 PM, Marc Burkhardt <marc@osknowledge.org> wrote: > > > > > >>On Thu, Oct 9, 2014 at 9:42 PM, Marc Burkhardt <marc@osknowledge.org> > >>wrote: > >>> I upgraded from 3.10 on that machine. 3.12 didn't work for me due to > >>a hibernation bug. The rest was left out... :/ > >> > >>If you still have the 3.12 kernel around, could you test if acpitool > >>-e worked there? > > > > Let me ask you a question: does it make sense to test 3.12 again because you know there's something changed regarding /proc/acpi/... or because it's the kernel I broke up on upgrading? > > Never mind. It broke after 3.14. I'll bisect. > The below patch fixes it for me. Looks like the line sizes changed and some are now exactly the right length to make it loop forever reading /proc/acpi/wakeup: --- a/src/acpitool.cpp +++ b/src/acpitool.cpp @@ -417,7 +417,7 @@ int Do_Fan_Info(int verbose) int Show_WakeUp_Devices(int verbose) { ifstream file_in; - char *filename, str[40]; + char *filename, str[80]; filename = "/proc/acpi/wakeup"; @@ -438,13 +438,13 @@ int Show_WakeUp_Devices(int verbose) } else { - file_in.getline(str, 40); // first line are just headers // + file_in.getline(str, 80); // first line are just headers // cout<<" "<<str<<endl; cout<<" ---------------------------------------"<<endl; int t = 1; while(!file_in.eof()) { - file_in.getline(str, 40); + file_in.getline(str, 80); if (strlen(str)!=0) // avoid printing last empty line // { cout<<" "<<t<<". "<<str<<endl; ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: acpitool - /proc/acpi/wakeup 2014-10-09 20:27 ` Chuck Ebbert @ 2014-10-09 21:28 ` Frans Klaver 0 siblings, 0 replies; 10+ messages in thread From: Frans Klaver @ 2014-10-09 21:28 UTC (permalink / raw) To: Chuck Ebbert; +Cc: Marc Burkhardt, linux-kernel@vger.kernel.org On Thu, Oct 9, 2014 at 10:27 PM, Chuck Ebbert <cebbert.lkml@gmail.com> wrote: > On Thu, 9 Oct 2014 22:16:11 +0200 > Frans Klaver <fransklaver@gmail.com> wrote: > >> On Thu, Oct 9, 2014 at 9:58 PM, Marc Burkhardt <marc@osknowledge.org> wrote: >> > >> > >> >>On Thu, Oct 9, 2014 at 9:42 PM, Marc Burkhardt <marc@osknowledge.org> >> >>wrote: >> >>> I upgraded from 3.10 on that machine. 3.12 didn't work for me due to >> >>a hibernation bug. The rest was left out... :/ >> >> >> >>If you still have the 3.12 kernel around, could you test if acpitool >> >>-e worked there? >> > >> > Let me ask you a question: does it make sense to test 3.12 again because you know there's something changed regarding /proc/acpi/... or because it's the kernel I broke up on upgrading? >> >> Never mind. It broke after 3.14. I'll bisect. >> > > The below patch fixes it for me. Looks like the line sizes changed > and some are now exactly the right length to make it loop forever > reading /proc/acpi/wakeup: > > > --- a/src/acpitool.cpp > +++ b/src/acpitool.cpp > @@ -417,7 +417,7 @@ int Do_Fan_Info(int verbose) > int Show_WakeUp_Devices(int verbose) > { > ifstream file_in; > - char *filename, str[40]; > + char *filename, str[80]; > > filename = "/proc/acpi/wakeup"; > > @@ -438,13 +438,13 @@ int Show_WakeUp_Devices(int verbose) > } > else > { > - file_in.getline(str, 40); // first line are just headers // > + file_in.getline(str, 80); // first line are just headers // > cout<<" "<<str<<endl; > cout<<" ---------------------------------------"<<endl; > int t = 1; > while(!file_in.eof()) > { > - file_in.getline(str, 40); > + file_in.getline(str, 80); > if (strlen(str)!=0) // avoid printing last empty line // > { > cout<<" "<<t<<". "<<str<<endl; Oh my. Why not use the std::string version of getline? I doubt we should count this as "breaking userspace".. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-10-09 21:28 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-10-09 19:04 acpitool - /proc/acpi/wakeup Marc Burkhardt 2014-10-09 19:13 ` Marc Burkhardt 2014-10-09 19:25 ` Frans Klaver 2014-10-09 19:31 ` Frans Klaver 2014-10-09 19:42 ` Marc Burkhardt 2014-10-09 19:48 ` Frans Klaver 2014-10-09 19:58 ` Marc Burkhardt 2014-10-09 20:16 ` Frans Klaver 2014-10-09 20:27 ` Chuck Ebbert 2014-10-09 21:28 ` Frans Klaver
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox