* [PATCH] mfd: arizona-spi: Add lines after declarations - checkpatch catch
@ 2014-10-15 8:38 Will Sheppard
2014-10-15 9:04 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Will Sheppard @ 2014-10-15 8:38 UTC (permalink / raw)
To: linux-kernel, lee.jones; +Cc: sameo, patches, Will Sheppard
This was found whilst running checkpatch.pl on arizona-spi.
WARNING: Missing a blank line after declarations
+ struct arizona *arizona = spi_get_drvdata(spi);
+ arizona_dev_exit(arizona);
Signed-off-by: Will Sheppard <wsheppard@embedded-bits.co.uk>
---
drivers/mfd/arizona-spi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
index 5145d78..8ef58bc 100644
--- a/drivers/mfd/arizona-spi.c
+++ b/drivers/mfd/arizona-spi.c
@@ -75,7 +75,9 @@ static int arizona_spi_probe(struct spi_device *spi)
static int arizona_spi_remove(struct spi_device *spi)
{
struct arizona *arizona = spi_get_drvdata(spi);
+
arizona_dev_exit(arizona);
+
return 0;
}
--
1.8.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: arizona-spi: Add lines after declarations - checkpatch catch
2014-10-15 8:38 [PATCH] mfd: arizona-spi: Add lines after declarations - checkpatch catch Will Sheppard
@ 2014-10-15 9:04 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-10-15 9:04 UTC (permalink / raw)
To: Will Sheppard; +Cc: linux-kernel, sameo, patches
On Wed, 15 Oct 2014, Will Sheppard wrote:
> This was found whilst running checkpatch.pl on arizona-spi.
>
> WARNING: Missing a blank line after declarations
> + struct arizona *arizona = spi_get_drvdata(spi);
> + arizona_dev_exit(arizona);
>
> Signed-off-by: Will Sheppard <wsheppard@embedded-bits.co.uk>
> ---
> drivers/mfd/arizona-spi.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied for v3.19.
> diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
> index 5145d78..8ef58bc 100644
> --- a/drivers/mfd/arizona-spi.c
> +++ b/drivers/mfd/arizona-spi.c
> @@ -75,7 +75,9 @@ static int arizona_spi_probe(struct spi_device *spi)
> static int arizona_spi_remove(struct spi_device *spi)
> {
> struct arizona *arizona = spi_get_drvdata(spi);
> +
> arizona_dev_exit(arizona);
> +
> return 0;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-15 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-15 8:38 [PATCH] mfd: arizona-spi: Add lines after declarations - checkpatch catch Will Sheppard
2014-10-15 9:04 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox