From: Brian Vandre <bvandre@gmail.com>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
gregkh@linuxfoundation.org, jic23@kernel.org,
alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org,
marex@denx.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters
Date: Wed, 22 Oct 2014 21:02:13 -0500 [thread overview]
Message-ID: <20141023020213.GA30907@brian-U> (raw)
In-Reply-To: <54484219.5000708@gmx.de>
On Thu, Oct 23, 2014 at 01:47:37AM +0200, Hartmut Knaack wrote:
> Sudip Mukherjee schrieb am 22.10.2014 06:21:
> > On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
> >> This fixes the 2 checkpatch.pl warnings:
> >> WARNING: line over 80 characters
> >>
> > please check your patch with --strict option of checkpatch.pl , and you will get :
> > "Alignment should match open parenthesis" .
> >
> Good point, but what solution would you propose?
Hey All,
Thanks for all the feedback. This is my first attempt at a patch so I thank you all
for helping me through it. I have a question about the strict option on checkpatch.pl.
I thought that the stict option was not necessarily part of the coding standards but
more of a nice to have. Should I be always using the strict option?
On this particular patch if I were to align to the open parenthesis it would push the
comment "/* trigger DELAY unit#3 */" off to the next line which I thought we be less
clear. If --strict is optional then I would argue to leave it the way it is, but again
this is my first time and I am learning.
If I were to align to the parenthesis should I just move the comment to the next line
or possibly delete the comment altogether? The code is clear and the comment might not
be necessary but I didn't want to remove anything the original author wrote.
Thanks,
Brian Vandre
next prev parent reply other threads:[~2014-10-23 2:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 2:48 [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Brian Vandre
2014-10-21 2:48 ` [PATCH 1/2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-23 10:39 ` Daniel Baluta
2014-10-21 2:48 ` [PATCH 2/2] " Brian Vandre
2014-10-21 7:29 ` [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Alexandre Belloni
2014-10-21 22:56 ` [PATCH v2] " Brian Vandre
2014-10-21 22:56 ` [PATCH v2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-22 4:21 ` Sudip Mukherjee
2014-10-22 23:47 ` Hartmut Knaack
2014-10-23 2:02 ` Brian Vandre [this message]
2014-10-23 3:23 ` Joe Perches
2014-10-23 9:46 ` Sudip Mukherjee
2014-10-23 10:50 ` Lars-Peter Clausen
2014-10-23 12:42 ` Brian Vandre
2014-10-23 12:53 ` Brian Vandre
2014-10-23 13:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023020213.GA30907@brian-U \
--to=bvandre@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox