From: Brian Vandre <bvandre@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
gregkh@linuxfoundation.org, jic23@kernel.org,
alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org,
marex@denx.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters
Date: Thu, 23 Oct 2014 07:42:43 -0500 [thread overview]
Message-ID: <20141023124243.GA10433@brian-U> (raw)
In-Reply-To: <5448DD58.7030705@metafoo.de>
On Thu, Oct 23, 2014 at 12:50:00PM +0200, Lars-Peter Clausen wrote:
> On 10/22/2014 06:21 AM, Sudip Mukherjee wrote:
> >On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
> >>This fixes the 2 checkpatch.pl warnings:
> >>WARNING: line over 80 characters
> >>
> >please check your patch with --strict option of checkpatch.pl , and you will get :
> >"Alignment should match open parenthesis" .
>
> Those checkpatch warnings are suggestions, not hard requirements.
> The idea is to improve code legibility, but if the change has the
> adverse effect the warning can and should be ignored. Also when
> making a change you should keep the existing indention style of a
> file.
>
> - Lars
I think my patch does follow the style of the original file. If you run checkpatch.pl --strict
on the whole file you will get many open parenthesis warnings. I believe it does make it slightly
more legibile.
next prev parent reply other threads:[~2014-10-23 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 2:48 [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Brian Vandre
2014-10-21 2:48 ` [PATCH 1/2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-23 10:39 ` Daniel Baluta
2014-10-21 2:48 ` [PATCH 2/2] " Brian Vandre
2014-10-21 7:29 ` [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Alexandre Belloni
2014-10-21 22:56 ` [PATCH v2] " Brian Vandre
2014-10-21 22:56 ` [PATCH v2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-22 4:21 ` Sudip Mukherjee
2014-10-22 23:47 ` Hartmut Knaack
2014-10-23 2:02 ` Brian Vandre
2014-10-23 3:23 ` Joe Perches
2014-10-23 9:46 ` Sudip Mukherjee
2014-10-23 10:50 ` Lars-Peter Clausen
2014-10-23 12:42 ` Brian Vandre [this message]
2014-10-23 12:53 ` Brian Vandre
2014-10-23 13:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023124243.GA10433@brian-U \
--to=bvandre@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox