* [PATCH] asus-nb-wmi: Add wapf4 quirk for the X550VB
@ 2014-10-22 12:32 Stanislaw Gruszka
2014-10-25 5:11 ` Darren Hart
0 siblings, 1 reply; 4+ messages in thread
From: Stanislaw Gruszka @ 2014-10-22 12:32 UTC (permalink / raw)
To: platform-driver-x86; +Cc: linux-kernel, Darren Hart
As reported here: http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23
the X550VB needs wapf=4 too.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 3a4951f..c1a6cd6 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -182,6 +182,15 @@ static const struct dmi_system_id asus_quirks[] = {
},
{
.callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. X550VB",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X550VB"),
+ },
+ .driver_data = &quirk_asus_wapf4,
+ },
+ {
+ .callback = dmi_matched,
.ident = "ASUSTeK COMPUTER INC. X55A",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] asus-nb-wmi: Add wapf4 quirk for the X550VB
2014-10-22 12:32 [PATCH] asus-nb-wmi: Add wapf4 quirk for the X550VB Stanislaw Gruszka
@ 2014-10-25 5:11 ` Darren Hart
2014-10-26 10:23 ` [PATCH v2] " Stanislaw Gruszka
0 siblings, 1 reply; 4+ messages in thread
From: Darren Hart @ 2014-10-25 5:11 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: platform-driver-x86, linux-kernel
On Wed, Oct 22, 2014 at 02:32:52PM +0200, Stanislaw Gruszka wrote:
Hi Stanislaw,
> As reported here: http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23
> the X550VB needs wapf=4 too.
>
Please provide a self sufficient changelog, that, independent of a bugzilla
link, provides enough information to understand what the problem is, and why
this is the correct fix.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] asus-nb-wmi: Add wapf4 quirk for the X550VB
2014-10-25 5:11 ` Darren Hart
@ 2014-10-26 10:23 ` Stanislaw Gruszka
2014-10-28 4:14 ` Darren Hart
0 siblings, 1 reply; 4+ messages in thread
From: Stanislaw Gruszka @ 2014-10-26 10:23 UTC (permalink / raw)
To: Darren Hart; +Cc: platform-driver-x86, linux-kernel
X550VB as many others Asus laptops need wapf4 quirk to make RFKILL
switch be functional. Otherwise system boots with wireless card
disabled and is only possible to enable it by suspend/resume.
Bug report:
http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23
Reported-and-tested-by: Vratislav Podzimek <vpodzime@redhat.com>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
v1 -> v2: update changelog
drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 3a4951f..c1a6cd6 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -182,6 +182,15 @@ static const struct dmi_system_id asus_quirks[] = {
},
{
.callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. X550VB",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X550VB"),
+ },
+ .driver_data = &quirk_asus_wapf4,
+ },
+ {
+ .callback = dmi_matched,
.ident = "ASUSTeK COMPUTER INC. X55A",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] asus-nb-wmi: Add wapf4 quirk for the X550VB
2014-10-26 10:23 ` [PATCH v2] " Stanislaw Gruszka
@ 2014-10-28 4:14 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2014-10-28 4:14 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: platform-driver-x86, linux-kernel
On Sun, Oct 26, 2014 at 11:23:55AM +0100, Stanislaw Gruszka wrote:
> X550VB as many others Asus laptops need wapf4 quirk to make RFKILL
> switch be functional. Otherwise system boots with wireless card
> disabled and is only possible to enable it by suspend/resume.
>
> Bug report:
> http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23
>
> Reported-and-tested-by: Vratislav Podzimek <vpodzime@redhat.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Queued, thanks Stanislaw.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-28 4:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 12:32 [PATCH] asus-nb-wmi: Add wapf4 quirk for the X550VB Stanislaw Gruszka
2014-10-25 5:11 ` Darren Hart
2014-10-26 10:23 ` [PATCH v2] " Stanislaw Gruszka
2014-10-28 4:14 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox