* [PATCH] platform: x86: remove redundant variable in hp-wireless.c
@ 2014-11-04 23:47 Giedrius Statkevicius
2014-11-07 18:28 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Giedrius Statkevicius @ 2014-11-04 23:47 UTC (permalink / raw)
To: dvhart; +Cc: platform-driver-x86, linux-kernel, Giedrius Statkevičius
Remove a variable because it only holds the results of a function call
and then gets returned so instead just return the result of a function
call.
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
---
drivers/platform/x86/hp-wireless.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c
index 415348f..670c62b 100644
--- a/drivers/platform/x86/hp-wireless.c
+++ b/drivers/platform/x86/hp-wireless.c
@@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
static int hpwl_add(struct acpi_device *device)
{
- int err;
-
- err = hp_wireless_input_setup();
- return err;
+ return hp_wireless_input_setup();
}
static int hpwl_remove(struct acpi_device *device)
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] platform: x86: remove redundant variable in hp-wireless.c
2014-11-04 23:47 [PATCH] platform: x86: remove redundant variable in hp-wireless.c Giedrius Statkevicius
@ 2014-11-07 18:28 ` Darren Hart
2014-11-07 23:03 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Darren Hart @ 2014-11-07 18:28 UTC (permalink / raw)
To: Giedrius Statkevicius
Cc: platform-driver-x86, linux-kernel, Rafael Wysocki,
Linux ACPI Mailing List
On Wed, Nov 05, 2014 at 01:47:19AM +0200, Giedrius Statkevicius wrote:
> Remove a variable because it only holds the results of a function call
> and then gets returned so instead just return the result of a function
> call.
>
> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
> ---
> drivers/platform/x86/hp-wireless.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c
> index 415348f..670c62b 100644
> --- a/drivers/platform/x86/hp-wireless.c
> +++ b/drivers/platform/x86/hp-wireless.c
> @@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
>
> static int hpwl_add(struct acpi_device *device)
> {
> - int err;
> -
> - err = hp_wireless_input_setup();
> - return err;
> + return hp_wireless_input_setup();
Since acpi_device_probe() does not print a warning if add() fails, it might be
preferable to print the message here, rather than ignoring it completely.
Rafael?
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] platform: x86: remove redundant variable in hp-wireless.c
2014-11-07 18:28 ` Darren Hart
@ 2014-11-07 23:03 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-11-07 23:03 UTC (permalink / raw)
To: Darren Hart
Cc: Giedrius Statkevicius, platform-driver-x86, linux-kernel,
Linux ACPI Mailing List
On Friday, November 07, 2014 10:28:23 AM Darren Hart wrote:
> On Wed, Nov 05, 2014 at 01:47:19AM +0200, Giedrius Statkevicius wrote:
> > Remove a variable because it only holds the results of a function call
> > and then gets returned so instead just return the result of a function
> > call.
> >
> > Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
> > ---
> > drivers/platform/x86/hp-wireless.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c
> > index 415348f..670c62b 100644
> > --- a/drivers/platform/x86/hp-wireless.c
> > +++ b/drivers/platform/x86/hp-wireless.c
> > @@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
> >
> > static int hpwl_add(struct acpi_device *device)
> > {
> > - int err;
> > -
> > - err = hp_wireless_input_setup();
> > - return err;
> > + return hp_wireless_input_setup();
>
> Since acpi_device_probe() does not print a warning if add() fails, it might be
> preferable to print the message here, rather than ignoring it completely.
>
> Rafael?
Sounds reasonable.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-07 22:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04 23:47 [PATCH] platform: x86: remove redundant variable in hp-wireless.c Giedrius Statkevicius
2014-11-07 18:28 ` Darren Hart
2014-11-07 23:03 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox