From: Lee Jones <lee.jones@linaro.org>
To: NeilBrown <neilb@suse.de>
Cc: Tony Lindgren <tony@atomide.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
GTA04 owners <gta04-owner@goldelico.com>
Subject: Re: [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.
Date: Mon, 10 Nov 2014 09:07:38 +0000 [thread overview]
Message-ID: <20141110090738.GA21424@x1> (raw)
In-Reply-To: <20141108112227.256f93ce@notabene.brown>
On Sat, 08 Nov 2014, NeilBrown wrote:
>
> commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> mfd: twl4030-power: Add generic reset configuration
>
> claims:
> Let's add device tree support and configure things for warm reset
> as the default when compatible = "ti,twl4030-power".
> and
> Documentation/devicetree/bindings/mfd/twl4030-power.txt
> claims that "ti,twl4030-power" is still a valid "compatible" setting.
>
> However the current driver fails to probe with that 'compatible'
> setting.
> Restore the old default.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Tony should take a look at this.
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4d3ff3771491..1a7794f6be15 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + .data = NULL,
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-11-10 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 0:22 [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again NeilBrown
2014-11-08 7:24 ` [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again Dr. H. Nikolaus Schaller
2014-11-10 1:27 ` NeilBrown
2014-11-10 9:09 ` Lee Jones
2014-11-10 9:07 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110090738.GA21424@x1 \
--to=lee.jones@linaro.org \
--cc=gta04-owner@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox