From: NeilBrown <neilb@suse.de>
To: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Tony Lindgren <tony@atomide.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
List for communicating with real GTA04 owners
<gta04-owner@goldelico.com>
Subject: Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.
Date: Mon, 10 Nov 2014 12:27:22 +1100 [thread overview]
Message-ID: <20141110122722.34b27c4c@notabene.brown> (raw)
In-Reply-To: <ABCF9D6C-DD71-4DE3-BF1E-3C41DC8086FF@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]
On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"
<hns@goldelico.com> wrote:
>
> Am 08.11.2014 um 01:22 schrieb NeilBrown <neilb@suse.de>:
>
> >
> > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> > mfd: twl4030-power: Add generic reset configuration
> >
> > claims:
> > Let's add device tree support and configure things for warm reset
> > as the default when compatible = "ti,twl4030-power".
> > and
> > Documentation/devicetree/bindings/mfd/twl4030-power.txt
> > claims that "ti,twl4030-power" is still a valid "compatible" setting.
> >
> > However the current driver fails to probe with that 'compatible'
> > setting.
> > Restore the old default.
>
> I think this is a duplicate to
>
> 599a1ca80d1d8269d54fdc4abdec8e65141381fe
>
> (in linux-next)
Ahh, so it is. Thanks.
NeilBrown
>
> >
> > Signed-off-by: NeilBrown <neilb@suse.de>
> >
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > index 4d3ff3771491..1a7794f6be15 100644
> > --- a/drivers/mfd/twl4030-power.c
> > +++ b/drivers/mfd/twl4030-power.c
> > @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
> >
> > static struct of_device_id twl4030_power_of_match[] = {
> > {
> > + .compatible = "ti,twl4030-power",
> > + .data = NULL,
> > + },
> > + {
> > .compatible = "ti,twl4030-power-reset",
> > .data = &omap3_reset,
> > },
> > _______________________________________________
> > Gta04-owner mailing list
> > Gta04-owner@goldelico.com
> > http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-11-10 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 0:22 [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again NeilBrown
2014-11-08 7:24 ` [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again Dr. H. Nikolaus Schaller
2014-11-10 1:27 ` NeilBrown [this message]
2014-11-10 9:09 ` Lee Jones
2014-11-10 9:07 ` [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110122722.34b27c4c@notabene.brown \
--to=neilb@suse.de \
--cc=gta04-owner@goldelico.com \
--cc=hns@goldelico.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox