From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL for v3.18-rc1] media updates
Date: Mon, 10 Nov 2014 18:54:33 -0200 [thread overview]
Message-ID: <20141110185433.3c53e438@recife.lan> (raw)
In-Reply-To: <1415652356.21229.31.camel@x220>
Em Mon, 10 Nov 2014 21:45:56 +0100
Paul Bolle <pebolle@tiscali.nl> escreveu:
> Hi Mauro,
>
> On Mon, 2014-10-20 at 10:31 +0200, Paul Bolle wrote:
> > This became commit 38a073116525 ("[media] omap: be sure that MMU is
> > there for COMPILE_TEST").
> >
> > As I reported in
> > http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/82299
> > it adds an (optional) test for a Kconfig symbol HAS_MMU. There's no
> > such symbol. So that test will always fail. Did you perhaps mean
> > simply "MMU"?
>
> This typo is still present in both next-20141110 and v3.18-rc4. And I've
> first reported it nearly two months ago. I see two fixes:
> 1) s/HAS_MMU/MMU/
> 2) s/ || (COMPILE_TEST && HAS_MMU)//
>
> Which would you prefer?
Hmm... Probably patchwork didn't get your patch.
IMHO, the best would be:
depends on HAS_MMU
depends on ARCH_OMAP2 || ARCH_OMAP3 || COMPILE_TEST
Regards,
Mauro
next prev parent reply other threads:[~2014-11-10 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 17:18 [GIT PULL for v3.18-rc1] media updates Mauro Carvalho Chehab
2014-10-20 8:31 ` Paul Bolle
2014-11-10 20:45 ` Paul Bolle
2014-11-10 20:54 ` Mauro Carvalho Chehab [this message]
2014-11-10 21:05 ` Paul Bolle
2014-11-10 22:20 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110185433.3c53e438@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=torvalds@linux-foundation.org \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox