From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: core: export function to check if regulator always on
Date: Wed, 12 Nov 2014 11:35:41 +0000 [thread overview]
Message-ID: <20141112113541.GD3815@sirena.org.uk> (raw)
In-Reply-To: <20141112111835.GA12635@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Wed, Nov 12, 2014 at 11:18:35AM +0000, Richard Fitzgerald wrote:
> Export a function to allow a consumer to check if its supply
> regulator is always on. Drivers might wish to take different
> action based on this - for example skipping time-consuming
> power-saving preparations that are irrelevant if the regulator
> cannot be disabled.
I'd like to see a user here, and I'd also like to understand why this is
a better approach than using a callback to postpone these expensive
operations until the regulator is actually powered off like we already
do for some things like register cache resyncs. That is normally better
since it also avoids the work in cases where the regulator isn't always
on like reenabling during a delayed powerdown or shared regulators.
You're also missing a !CONFIG_REGULATOR stub.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-12 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 11:18 [PATCH] regulator: core: export function to check if regulator always on Richard Fitzgerald
2014-11-12 11:35 ` Mark Brown [this message]
2014-11-12 13:07 ` Richard Fitzgerald
2014-11-12 14:58 ` Mark Brown
2014-11-12 16:58 ` Richard Fitzgerald
2014-11-12 17:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112113541.GD3815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox