Re: [PATCH] regulator: core: export function to check if regulator always on

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

On Wed, Nov 12, 2014 at 01:07:35PM +0000, Richard Fitzgerald wrote:
> On Wed, Nov 12, 2014 at 11:35:41AM +0000, Mark Brown wrote:

> > I'd like to see a user here,

> The user will be the Arizona codec drivers but I wanted to upstream
> this patch first for discussion.

My point is that the code using the API is useful input to the
discussion.

> > and I'd also like to understand why this is
> > a better approach than using a callback to postpone these expensive
> > operations until the regulator is actually powered off like we already
> > do for some things like register cache resyncs.  That is normally better
> > since it also avoids the work in cases where the regulator isn't always
> > on like reenabling during a delayed powerdown or shared regulators.

> The runtime_suspend() for the Arizona drivers has to do a bunch of
> preparation before disabling the DCVDD regulator (and there's more
> preparation steps that need to be upstreamed). There's no point doing
> any of this if at the end the regulator isn't going to switch off.

I'm not sure that this addresses my concern about postponing the
expensive work until the regulator is actually powered off at all?

> > You're also missing a !CONFIG_REGULATOR stub.

> It's there at the end of the patch, returning 1.

Bah, so it is.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]