* [PATCH] spi/rockchip: remove redundant call to spi_master_put()
@ 2014-11-11 13:22 Laurentiu Palcu
2014-11-12 15:04 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Laurentiu Palcu @ 2014-11-11 13:22 UTC (permalink / raw)
To: Heiko Stuebner, Mark Brown
Cc: linux-rockchip, linux-spi, linux-kernel, Laurentiu Palcu
The call to spi_master_put() in rockchip_spi_remove() is redundant since
the master is registered using devm_. This patch removes it.
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
drivers/spi/spi-rockchip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 3afc266..e8cfe6c 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -724,8 +724,6 @@ static int rockchip_spi_remove(struct platform_device *pdev)
if (rs->dma_rx.ch)
dma_release_channel(rs->dma_rx.ch);
- spi_master_put(master);
-
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi/rockchip: remove redundant call to spi_master_put()
2014-11-11 13:22 [PATCH] spi/rockchip: remove redundant call to spi_master_put() Laurentiu Palcu
@ 2014-11-12 15:04 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-11-12 15:04 UTC (permalink / raw)
To: Laurentiu Palcu; +Cc: Heiko Stuebner, linux-rockchip, linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
On Tue, Nov 11, 2014 at 03:22:51PM +0200, Laurentiu Palcu wrote:
> The call to spi_master_put() in rockchip_spi_remove() is redundant since
> the master is registered using devm_. This patch removes it.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-12 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 13:22 [PATCH] spi/rockchip: remove redundant call to spi_master_put() Laurentiu Palcu
2014-11-12 15:04 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).