From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: drbd-user@lists.linbit.com, drbd-dev@lists.linbit.com,
linux-kernel@vger.kernel.org
Subject: Re: [DRBD-user] FIX MEs for spinlocks in drbd_worker.c
Date: Sat, 22 Nov 2014 23:08:01 +0100 [thread overview]
Message-ID: <20141122220801.GX307@soda.linbit> (raw)
In-Reply-To: <546E6D1F.9070300@gmail.com>
On Thu, Nov 20, 2014 at 05:37:19PM -0500, nick wrote:
> Greetings Lars,
> I am wondering about removing the spin locks around the linked list
> operators in worker.c or do we need to test it first it first on
> actual hardware.
> Cheers Nick
Unless you have deep insight in the inner workings of DRBD
and their interactions, I'd strongly recommend to go find
some other fixmes.
That is much more complicated than just removing those lines and hope
for the best. Otherwise they would not be there (and not FIXME tag to
find them).
Maybe you just want to reverse-sort your grep for fixmes,
so that the bottom of the list gets some love, too.
Thanks,
Lars
parent reply other threads:[~2014-11-22 22:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <546E6D1F.9070300@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141122220801.GX307@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox