* Re: [DRBD-user] FIX MEs for spinlocks in drbd_worker.c
[not found] <546E6D1F.9070300@gmail.com>
@ 2014-11-22 22:08 ` Lars Ellenberg
0 siblings, 0 replies; only message in thread
From: Lars Ellenberg @ 2014-11-22 22:08 UTC (permalink / raw)
To: drbd-user, drbd-dev, linux-kernel
On Thu, Nov 20, 2014 at 05:37:19PM -0500, nick wrote:
> Greetings Lars,
> I am wondering about removing the spin locks around the linked list
> operators in worker.c or do we need to test it first it first on
> actual hardware.
> Cheers Nick
Unless you have deep insight in the inner workings of DRBD
and their interactions, I'd strongly recommend to go find
some other fixmes.
That is much more complicated than just removing those lines and hope
for the best. Otherwise they would not be there (and not FIXME tag to
find them).
Maybe you just want to reverse-sort your grep for fixmes,
so that the bottom of the list gets some love, too.
Thanks,
Lars
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-11-22 22:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <546E6D1F.9070300@gmail.com>
2014-11-22 22:08 ` [DRBD-user] FIX MEs for spinlocks in drbd_worker.c Lars Ellenberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox