* [patch] sh: off by one BUG_ON() in setup_bootmem_node()
[not found] <CAMuHMdVxCUYkaC5wzHi-o6knD6ugFudTdh3PJz5JCwv-std3GA@mail.gmail.com>
@ 2014-12-04 11:01 ` Dan Carpenter
2014-12-04 11:04 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-12-04 11:01 UTC (permalink / raw)
To: linux-sh, Andrew Morton
Cc: linux-kernel, kernel-janitors, Geert Uytterhoeven, Paul Mundt
This off by one bug is harmless but it upsets the static checkers and
the code is obvious so it doesn't hurt to fix it. The Smatch warning
is:
arch/sh/mm/numa.c:47 setup_bootmem_node()
error: buffer overflow 'node_data' 1024 <= 1024
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/sh/mm/numa.c b/arch/sh/mm/numa.c
index 3d85225..bce52ba 100644
--- a/arch/sh/mm/numa.c
+++ b/arch/sh/mm/numa.c
@@ -31,7 +31,7 @@ void __init setup_bootmem_node(int nid, unsigned long start, unsigned long end)
unsigned long bootmem_paddr;
/* Don't allow bogus node assignment */
- BUG_ON(nid > MAX_NUMNODES || nid <= 0);
+ BUG_ON(nid >= MAX_NUMNODES || nid <= 0);
start_pfn = start >> PAGE_SHIFT;
end_pfn = end >> PAGE_SHIFT;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] sh: off by one BUG_ON() in setup_bootmem_node()
2014-12-04 11:01 ` [patch] sh: off by one BUG_ON() in setup_bootmem_node() Dan Carpenter
@ 2014-12-04 11:04 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-12-04 11:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Linux-sh list, Andrew Morton, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Paul Mundt
On Thu, Dec 4, 2014 at 12:01 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This off by one bug is harmless but it upsets the static checkers and
> the code is obvious so it doesn't hurt to fix it. The Smatch warning
> is:
>
> arch/sh/mm/numa.c:47 setup_bootmem_node()
> error: buffer overflow 'node_data' 1024 <= 1024
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> diff --git a/arch/sh/mm/numa.c b/arch/sh/mm/numa.c
> index 3d85225..bce52ba 100644
> --- a/arch/sh/mm/numa.c
> +++ b/arch/sh/mm/numa.c
> @@ -31,7 +31,7 @@ void __init setup_bootmem_node(int nid, unsigned long start, unsigned long end)
> unsigned long bootmem_paddr;
>
> /* Don't allow bogus node assignment */
> - BUG_ON(nid > MAX_NUMNODES || nid <= 0);
> + BUG_ON(nid >= MAX_NUMNODES || nid <= 0);
>
> start_pfn = start >> PAGE_SHIFT;
> end_pfn = end >> PAGE_SHIFT;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-04 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAMuHMdVxCUYkaC5wzHi-o6knD6ugFudTdh3PJz5JCwv-std3GA@mail.gmail.com>
2014-12-04 11:01 ` [patch] sh: off by one BUG_ON() in setup_bootmem_node() Dan Carpenter
2014-12-04 11:04 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox