* [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue
@ 2014-12-18 2:17 Eduardo Barretto
2014-12-18 3:11 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Barretto @ 2014-12-18 2:17 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
Fixed a coding style issue.
Signed-off-by: Eduardo Barretto <edusbarretto@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 55d2f56..de33a07 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -4123,12 +4123,11 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
pdrcode);
return 1;
- } else {
- /* bad code */
- pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
- pdrcode);
- return 0;
}
+ break;
}
- return 0; /* avoid compiler warnings */
+ /* bad code */
+ pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+ pdrcode);
+ return 0;
}
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue
2014-12-18 2:17 [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue Eduardo Barretto
@ 2014-12-18 3:11 ` Greg KH
2014-12-18 11:09 ` Eduardo Barretto
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-12-18 3:11 UTC (permalink / raw)
To: Eduardo Barretto; +Cc: devel, linux-kernel
On Thu, Dec 18, 2014 at 12:17:54AM -0200, Eduardo Barretto wrote:
> Fixed a coding style issue.
What coding style issue?
Be specific, you have lots of room here.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue
2014-12-18 3:11 ` Greg KH
@ 2014-12-18 11:09 ` Eduardo Barretto
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Barretto @ 2014-12-18 11:09 UTC (permalink / raw)
To: Greg KH; +Cc: devel, linux-kernel
Thank you for your feedback Greg!
I wonder if I should send a patch v3 or patch v2.1 with a better description.
Is there any standard that I should follow when sending another
version of a patch?
Thanks,
Best regards,
Eduardo dos Santos Barretto
On Thu, Dec 18, 2014 at 1:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Dec 18, 2014 at 12:17:54AM -0200, Eduardo Barretto wrote:
>> Fixed a coding style issue.
>
> What coding style issue?
>
> Be specific, you have lots of room here.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-18 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-18 2:17 [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue Eduardo Barretto
2014-12-18 3:11 ` Greg KH
2014-12-18 11:09 ` Eduardo Barretto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox